From: Thomas Rast <tr@thomasrast.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] commit-slab: declare functions "static inline"
Date: Mon, 25 Nov 2013 20:53:43 +0100 [thread overview]
Message-ID: <878uwc2r7c.fsf@thomasrast.ch> (raw)
In-Reply-To: <xmqqy54cxohs.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 25 Nov 2013 11:36:31 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Thomas Rast <tr@thomasrast.ch> writes:
>
>> This shuts up compiler warnings about unused functions.
>
> Thanks.
>
>> While there, also remove the redundant second declaration of
>> stat_##slabname##realloc.
>
> I think the latter was done very much deliberately to allow the
> using code to say:
>
> define_commit_slab(name, type);
>
> by ending the macro with something that requires a terminating
> semicolon. If you just remove it, doesn't it break the compilation
> by forcing the expanded source to define a function
>
> slabname ## _at(...)
> {
> ...
> };
>
> with a trailing and undesired semicolon?
Oooh. The sudden enlightenment.
--
Thomas Rast
tr@thomasrast.ch
next prev parent reply other threads:[~2013-11-25 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 19:01 [PATCH 0/2] commit-slab cleanups Thomas Rast
2013-11-25 19:02 ` [PATCH 1/2] commit-slab: document clear_$slabname() Thomas Rast
2013-11-25 20:24 ` Jonathan Nieder
2013-11-29 19:35 ` Thomas Rast
2013-11-25 20:39 ` Junio C Hamano
2013-11-27 10:39 ` Eric Sunshine
2013-11-25 19:02 ` [PATCH 2/2] commit-slab: declare functions "static inline" Thomas Rast
2013-11-25 19:36 ` Junio C Hamano
2013-11-25 19:53 ` Thomas Rast [this message]
2013-11-25 20:04 ` [PATCH v2] " Thomas Rast
2013-11-25 20:12 ` Jonathan Nieder
2013-11-25 20:15 ` Thomas Rast
2013-11-25 20:35 ` Jonathan Nieder
2013-11-25 20:33 ` Junio C Hamano
2013-11-25 20:23 ` Junio C Hamano
2013-12-01 10:36 ` [PATCH 2/2] " Duy Nguyen
2013-12-01 20:41 ` [PATCH] commit-slab: sizeof() the right type in xrealloc Thomas Rast
2013-12-02 15:35 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uwc2r7c.fsf@thomasrast.ch \
--to=tr@thomasrast.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).