From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Josh Sharpe <josh.m.sharpe@gmail.com>, <git@vger.kernel.org>
Subject: Re: feature request - have git honor nested .gitconfig files
Date: Sat, 23 Mar 2013 07:15:42 +0100 [thread overview]
Message-ID: <878v5ezlo1.fsf@pctrast.inf.ethz.ch> (raw)
In-Reply-To: <20130322183306.GA32448@sigill.intra.peff.net> (Jeff King's message of "Fri, 22 Mar 2013 14:33:06 -0400")
Jeff King <peff@peff.net> writes:
> I'd rather not invent a new language. It will either not be featureful
> enough, or will end up bloated. Or both. How about something like:
>
> [include]
> exec = "
> case \"$GIT_DIR\" in)
> */dev/*) cat ~/.config/git/dev-config ;;
> *) cat ~/.config/git/nondev-config ;;
> esac
> "
>
> It involves a shell invocation, but it's not like we parse config in a
> tight loop. Bonus points if git provides the name of the current config
> file, so exec can use relative paths like:
We do, however, parse config more than once:
$ strace git log -1 2>&1 | grep 'open.*config'
open("/home/thomas/.gitconfig", O_RDONLY) = 3
open(".git/config", O_RDONLY) = 3
open("/home/thomas/.gitconfig", O_RDONLY) = 3
open(".git/config", O_RDONLY) = 3
open("/home/thomas/.gitconfig", O_RDONLY) = 3
open(".git/config", O_RDONLY) = 3
open("/home/thomas/.gitconfig", O_RDONLY) = 3
open(".git/config", O_RDONLY) = 3
git-log might be somewhat of an extreme example, but I suspect it's at
least twice for all commands (once for repo detection and once for
actual parsing). So I further suspect that the slowdown in git's own
shellscripts (rebase) would be quite large if you actually spawned two
extra shells every time someone says 'git rev-parse ...'.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-03-23 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 16:50 feature request - have git honor nested .gitconfig files Josh Sharpe
2013-03-22 18:22 ` Jonathan Nieder
2013-03-22 18:33 ` Jeff King
2013-03-23 0:06 ` Jonathan Nieder
2013-03-23 8:03 ` Jeff King
2013-03-24 7:14 ` Junio C Hamano
2013-03-23 6:15 ` Thomas Rast [this message]
2013-03-23 8:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v5ezlo1.fsf@pctrast.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=josh.m.sharpe@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).