From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yasushi SHOJI Subject: Re: [PATCH] clone: the given repository dir should be relative to $PWD Date: Sun, 15 Oct 2006 12:09:20 +0900 Message-ID: <878xjiqnq7.wl@mail2.atmark-techno.com> References: <87ac3zqebs.wl@mail2.atmark-techno.com> <7v7iz274zy.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun Oct 15 05:09:37 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GYwNY-0002U9-Mk for gcvg-git@gmane.org; Sun, 15 Oct 2006 05:09:33 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbWJODJX (ORCPT ); Sat, 14 Oct 2006 23:09:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752004AbWJODJX (ORCPT ); Sat, 14 Oct 2006 23:09:23 -0400 Received: from shop.atmark-techno.com ([210.191.215.173]:65233 "EHLO mail2.atmark-techno.com") by vger.kernel.org with ESMTP id S1751985AbWJODJW (ORCPT ); Sat, 14 Oct 2006 23:09:22 -0400 Received: from localhost.atmark-techno.com (dns1.atmark-techno.com [210.191.215.170]) by mail2.atmark-techno.com (Postfix) with ESMTP id 537042297A; Sun, 15 Oct 2006 12:09:20 +0900 (JST) To: Junio C Hamano In-Reply-To: <7v7iz274zy.fsf@assigned-by-dhcp.cox.net> User-Agent: Wanderlust/2.14.0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: At Sat, 14 Oct 2006 18:16:33 -0700, Junio C Hamano wrote: > > Yasushi SHOJI writes: > > > the repository argument for git-clone should be relative to $PWD > > instead of the given target directory. The old behavior gave us > > surprising success and you need a few minute to know why it worked. > > > > GIT_DIR is already exported so no need to cd into $D. And this makes > > $PWD for git-fetch-pack, which is the actual command to take the given > > repository dir, the same as git-clone. > > > > Signed-off-by: Yasushi SHOJI > > --- > > > > While I'm not sure this is a feature we rely on or not, and I don't > > want to change the way people work, IMHO the old behaviour isn't > > appropriate for such higher level porcelain. > > > > The patch should be for post 1.4.3. > > Well spotted. I am fairly sure that this "clone from repository > relative to the target" is not intended behaviour. I'd say we > should fix this before 1.4.3. OK. if the behavior isn't intended and there ain't much user for it, I don't have any reason not to. my last sentence was more like a question to you rather than my statement. let's fix it before 1.4.3. > ... or are there any valid reason to keep the current behaviour > that I missed? I don't think so. I personally consider the behavior a bug. I just thought that we don't want to have user saying "hey, v1.4.3 doesn't work any more!" report, given that we are already in -rc2. -- yashi