From: "Philip Oakley" <philipoakley@iee.org>
To: "Stephen P. Smith" <ischis2@cox.net>,
"Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Stephen P. Smith" <ischis2@cox.net>
Subject: Re: [PATCH V3 0/2] specify commit by negative pattern
Date: Sun, 10 Jan 2016 13:25:42 -0000 [thread overview]
Message-ID: <87DF51336FE74635921A8C6857125F8B@PhilipOakley> (raw)
In-Reply-To: 1452392429-2578-1-git-send-email-ischis2@cox.net
From: "Stephen P. Smith" <ischis2@cox.net>
> Add support for negative pattern matching in <at> ^{/<pattern>} style
Has this become mangled by replacing the '@' with ' <at> ' ?
When I look at the update to revisions.txt it doesn't look like its touching
the '@' description.
Is this '@^' a new (for the documenation) combination. Or has the example
confused me?
> revision specifiers. So now you can find the first commit whose message
> doesn't match a pattern, complementing the existing positive matching.
> e.g.:
>
> $ git rebase -i <at> ^{/!-^WIP}
>
> My use-case is in having a "work, work, work, rebase, push"-style
> workflow, which generates a lot of "WIP foo" commits. While rebasing is
> usually handled via "git rebase -i origin/master", occasionally I will
> already have several "good, but not yet ready to push" commits hanging
> around while I finish work on related commits. In these situations, the
> ability to quickly "git diff <at> ^{/!-^WIP}" to get an overview of all
> changes "since the last one I was happy with", can be useful.
>
> This is the second version of the patch series. The previous attempt
> used the notation <at> ^{/!WIP}, rather than <at> ^{/!-WIP}, so the
> "modifier"
> was the '!' character. Now, '!' is taken as an indicator that the
> pattern is to be interpreted differently, and '-' is taken as an
> indicator of how it is to be interpreted differently. This follows
> recent discussion with "Junio C Hamano" <gitster <at> pobox.com> and
> much-less
> recent discussion archived at:
>
> http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477
>
> In summary, '!' is to be used as an "escape hatch", for further
> extension of the "name commit by pattern" functionality. Theorised future
> extensions indicated things like "what was to be searched",
> e.g.: <at> ^{/!(a=author)}. With only two interpretations of the '!'
> leader, for now (including the '!!' literal notation), adding such a
> verbose form, such as ' <at> ^{/!(negative)foo}', seemed inappropriate at
> this
> time. In the event that such verbose forms are ever implemented, this new
> form may act as a shorthand, for a basic case.
>
> Will Palmer (2):
> test for '!' handling in rev-parse's named commits
> object name: introduce '^{/!-<negative pattern>}' notation
>
> Documentation/revisions.txt | 11 +++++-----
> sha1_name.c | 20 ++++++++++++-----
> t/t1511-rev-parse-caret.sh | 53
> ++++++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 73 insertions(+), 11 deletions(-)
>
--
Philip
next prev parent reply other threads:[~2016-01-10 13:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 0:24 [PATCH v2 0/2] specify commit by negative pattern Will Palmer
2015-06-06 0:24 ` [PATCH v2 1/2] test for '!' handling in rev-parse's named commits Will Palmer
2015-06-06 0:24 ` [PATCH v2 2/2] object name: introduce '^{/!-<negative pattern>}' notation Will Palmer
2015-06-08 16:39 ` Junio C Hamano
2015-06-09 18:14 ` Will Palmer
2015-10-28 17:52 ` Junio C Hamano
2016-01-08 6:04 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Stephen Smith
2016-01-08 18:21 ` Junio C Hamano
2016-01-10 2:20 ` [PATCH V3 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-10 2:22 ` [PATCH V3 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-10 2:23 ` [PATCH V3 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-11 18:10 ` Philip Oakley
2016-01-13 4:51 ` [PATCH V4 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-13 4:51 ` [PATCH V4 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-13 4:52 ` [PATCH V4 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-13 19:15 ` Junio C Hamano
2016-01-31 0:06 ` [PATCH V5 " Stephen P. Smith
2016-02-01 21:42 ` Junio C Hamano
2016-01-10 13:25 ` Philip Oakley [this message]
2016-01-11 0:08 ` [PATCH V3 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-11 18:04 ` Philip Oakley
2016-01-10 14:14 ` Stephen & Linda Smith
2016-01-10 23:36 ` Philip Oakley
2016-01-09 1:55 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Stephen & Linda Smith
2016-01-09 2:18 ` Duy Nguyen
2016-01-11 17:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87DF51336FE74635921A8C6857125F8B@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ischis2@cox.net \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox