From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2024, #01; Tue, 3)
Date: Tue, 03 Dec 2024 16:30:35 +0100 [thread overview]
Message-ID: <87a5dckcmc.fsf@iotcl.com> (raw)
In-Reply-To: <xmqqed2pcled.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> * kn/the-repository (2024-11-27) 10 commits
> - packfile.c: remove unnecessary prepare_packed_git() call
> - midx: add repository to `multi_pack_index` struct
> - config: make `packed_git_(limit|window_size)` non-global variables
> - config: make `delta_base_cache_limit` a non-global variable
> - packfile: pass down repository to `for_each_packed_object`
> - packfile: pass down repository to `has_object[_kept]_pack`
> - packfile: pass down repository to `odb_pack_name`
> - packfile: pass `repository` to static function in the file
> - packfile: use `repository` from `packed_git` directly
> - packfile: add repository to struct `packed_git`
> (this branch is used by kn/midx-wo-the-repository.)
>
> Various implicit uses of 'the_repoository' in the packfile code
> have been eliminated.
>
> Will merge to 'next'?
> source: <cover.1732618495.git.karthik.188@gmail.com>
I did a thorough review of v7 and did another pass on the patches of v9.
I don't have any more comments. The only thing left is whether the
comments [1] & [2] from Kristoffer require a reroll. I'm fine either
way.
--
Toon
[1]: https://lore.kernel.org/git/9ca6bb8a-6597-400f-860f-3546296c441d@app.fastmail.com
[2]: https://lore.kernel.org/git/69d332a6-fee3-4801-b920-e16da730c1c7@app.fastmail.com
prev parent reply other threads:[~2024-12-03 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:48 What's cooking in git.git (Dec 2024, #01; Tue, 3) Junio C Hamano
2024-12-03 10:17 ` Patrick Steinhardt
2024-12-03 14:46 ` karthik nayak
2024-12-03 23:09 ` Junio C Hamano
2024-12-03 15:30 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5dckcmc.fsf@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).