From: Nix <nix@esperi.org.uk>
To: Jeff King <peff@peff.net>
Cc: Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [RFC PATCH] t5538: move http push tests out to t5542
Date: Fri, 30 May 2014 19:30:55 +0100 [thread overview]
Message-ID: <87a99z86g0.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <20140530172051.GB25443@sigill.intra.peff.net> (Jeff King's message of "Fri, 30 May 2014 13:20:52 -0400")
On 30 May 2014, Jeff King said:
> On Fri, May 30, 2014 at 11:29:10AM +0100, Nix wrote:
>
>> +test_expect_success 'push from shallow repo via http' '
>> + mv "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" shallow-upstream.git &&
>> + git clone --bare --no-local full "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
>> + (
>> + cd "$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
>> + git config http.receivepack true
>> + ) &&
>> + commit 1s0 &&
>
> This is a typo, no? The original is just "commit 10".
I have no *idea* where that came from. vi-wreckage I suspect.
> I think we can just drop that "1" from the expected output, though. It
> was created in the original by the "push from full to shallow" test (and
> is rather confusing, anyway, as it shares a name with the original "1").
Right.
--
NULL && (void)
next prev parent reply other threads:[~2014-05-30 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 22:44 git 2.0.0 PROFILE=BUILD check-phase problems with ./t5561-http-backend.sh; GIT_TEST_HTTPD=false problems with t5537-fetch-shallow.sh Nix
2014-05-30 1:06 ` Jeff King
2014-05-30 1:34 ` [PATCH] t5537: re-drop http tests Jeff King
2014-05-30 10:29 ` [RFC PATCH] t5538: move http push tests out to t5542 Nix
2014-05-30 17:20 ` Jeff King
2014-05-30 17:36 ` [PATCH v2] " Jeff King
2014-05-31 1:03 ` Duy Nguyen
2014-05-30 18:30 ` Nix [this message]
2014-05-30 17:26 ` [RFC PATCH] " Junio C Hamano
2014-05-30 18:33 ` Nix
2014-05-30 16:45 ` [PATCH] t5537: re-drop http tests Junio C Hamano
2014-05-30 9:28 ` git 2.0.0 PROFILE=BUILD check-phase problems with ./t5561-http-backend.sh; GIT_TEST_HTTPD=false problems with t5537-fetch-shallow.sh Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a99z86g0.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).