From: Jed Brown <jed@59A2.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: Re: git send-email --notmuch expr
Date: Wed, 25 Nov 2009 14:06:47 +0100 [thread overview]
Message-ID: <87aaya69eg.fsf@59A2.org> (raw)
In-Reply-To: <m3hbsic3l5.fsf@localhost.localdomain>
On Wed, 25 Nov 2009 02:16:52 -0800 (PST), Jakub Narebski <jnareb@gmail.com> wrote:
> (?: ... ) is in Perl non-capturing grouping
Thanks. Actually that code only executes under --compose, the headers
provided by format-patch all just come through untouched (but all the
interesting ones are duplicated). So it looks like we just need to
actually parse the relevant headers from format-patch, before the part
where the user gets prompted. These are a little harder because they
can span multiple lines. The current validation with --compose is a bit
broken: suppose the user sets the perfectly valid header
To: foo@example.com,
bar@example.com
The validation will strip the first line while issuing warning, but
send the second through untouched.
Jed
prev parent reply other threads:[~2009-11-25 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 2:49 git send-email --notmuch expr Jed Brown
2009-11-25 2:50 ` [PATCH 1/2] Added the --notmuch option to git format-patch Jed Brown
2009-11-25 2:50 ` [PATCH 2/2] Documentation for format-patch --notmuch Jed Brown
2009-11-25 10:16 ` git send-email --notmuch expr Jakub Narebski
2009-11-25 13:06 ` Jed Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaya69eg.fsf@59A2.org \
--to=jed@59a2.org \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox