From: Jim Meyering <jim@meyering.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: (resend) [PATCH] Don't ignore write failure from git-diff, git-log, etc.
Date: Sun, 24 Jun 2007 21:13:35 +0200 [thread overview]
Message-ID: <87abupyxls.fsf@rho.meyering.net> (raw)
In-Reply-To: <alpine.LFD.0.98.0706240951440.3593@woody.linux-foundation.org> (Linus Torvalds's message of "Sun\, 24 Jun 2007 10\:08\:01 -0700 \(PDT\)")
Linus Torvalds <torvalds@linux-foundation.org> wrote:
...
> I also don't think it's very _pretty_ code, and it violates my personal
> coding standards by adding way too deep indentation for the new error
> cases. It was already three indents deep (reasonably fine, but that
> NOT_BARE test wass already pretty ugly), but now it becomes five
> indentation levels deep at its deepest, which is just a sign that things
> should be split up.
I too disliked the form of my patch, and said so.
> I'd also like to know why it does that fcntl() is done,
In the quoted message, I explained that stdout was already
closed in some cases. The fcntl test avoids the EINVAL you'd
get for closing an already-closed file descriptor.
prev parent reply other threads:[~2007-06-24 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 15:13 (resend) [PATCH] Don't ignore write failure from git-diff, git-log, etc Jim Meyering
2007-06-24 9:01 ` Junio C Hamano
2007-06-24 17:08 ` Linus Torvalds
2007-06-24 17:10 ` [PATCH 1/2] Clean up internal command handling Linus Torvalds
2007-06-24 17:29 ` [PATCH 2/2] Check for IO errors after running a command Linus Torvalds
2007-06-25 9:44 ` Junio C Hamano
2007-06-25 13:20 ` Johannes Schindelin
2007-06-25 13:42 ` Johannes Sixt
2007-06-25 14:01 ` Jim Meyering
2007-06-25 15:57 ` Linus Torvalds
2007-06-26 13:33 ` Matthias Lederhofer
2007-06-25 19:54 ` Jim Meyering
2007-06-24 19:13 ` Jim Meyering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abupyxls.fsf@rho.meyering.net \
--to=jim@meyering.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).