git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [COGITO] fix git-tag-ls in the presence of all-packed tags
@ 2007-02-24  0:07 Nix
  0 siblings, 0 replies; only message in thread
From: Nix @ 2007-02-24  0:07 UTC (permalink / raw)
  To: git, Petr Baudis

(I don't know if cogito is dead (no changes for two months), but on the
off-chance that it isn't here's a tiny patch.)


Rely on the ref walker to determine if there are any tags.
(Just consulting refs/tags fails wrongly if all tags are packed.)

Signed-off-by: Nick Alcock <nix@esperi.org.uk>

diff --git a/cg-tag-ls b/cg-tag-ls
index f4c776c..724f428 100755
--- a/cg-tag-ls
+++ b/cg-tag-ls
@@ -28,10 +28,7 @@ _git_wc_unneeded=1
 
 msg_no_tags="no tags present, please see cg-tag(1)"
 
-[ -d "$_git/refs/tags" ] || die "$msg_no_tags"
-
-[ "$(find "$_git/refs/tags" -follow -type f)" ] \
-       || die "$msg_no_tags"
+[ "x$(git-for-each-ref --count=1 --format=present refs/tags)" = "xpresent" ] || die "$msg_no_tags"
 
 maxlen="$(git-for-each-ref --format="%(refname)" refs/tags | column_width "refs/tags/")"
 

-- 
`In the future, company names will be a 32-character hex string.'
  --- Bruce Schneier on the shortage of company names

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-24  0:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-24  0:07 [COGITO] fix git-tag-ls in the presence of all-packed tags Nix

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).