* [PATCH] Shell syntax fix in git-reset
@ 2007-01-18 11:15 David Kågedal
2007-01-19 16:58 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: David Kågedal @ 2007-01-18 11:15 UTC (permalink / raw)
To: git
---
git-reset.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
My /bin/sh is a symlink to dash, which is probably why I got this and
few others.
diff --git a/git-reset.sh b/git-reset.sh
index bf2a058..fee6d98 100755
--- a/git-reset.sh
+++ b/git-reset.sh
@@ -43,7 +43,7 @@ case "$1" in --) shift ;; esac
# affecting the working tree nor HEAD.
if test $# != 0
then
- test "$reset_type" == "--mixed" ||
+ test "$reset_type" = "--mixed" ||
die "Cannot do partial $reset_type reset."
git-diff-index --cached $rev -- "$@" |
--
1.5.0.rc1.g04f3-dirty
--
David Kågedal
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Shell syntax fix in git-reset
2007-01-18 11:15 [PATCH] Shell syntax fix in git-reset David Kågedal
@ 2007-01-19 16:58 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2007-01-19 16:58 UTC (permalink / raw)
To: David Kågedal; +Cc: git
Thanks for catching this. With your fix,
$ git grep -e 'test .*==' -e '\[ .*==' -- '*.sh'
does not seem to hit anything else.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-19 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-18 11:15 [PATCH] Shell syntax fix in git-reset David Kågedal
2007-01-19 16:58 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).