From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Junio C Hamano <gitster@pobox.com>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG] push: pre-push hook that waits for stdin is slow
Date: Tue, 13 Jan 2026 23:10:16 +0200 [thread overview]
Message-ID: <87bjixi5hj.fsf@collabora.com> (raw)
In-Reply-To: <xmqq8qe1i6o7.fsf@gitster.g>
On Tue, 13 Jan 2026, Junio C Hamano <gitster@pobox.com> wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>> Thank you for filling out a Git bug report!
>> Please answer the following questions to help us understand your issue.
>>
>> What did you do before the bug happened? (Steps to reproduce your issue)
>>
>> Used `git push` with a pre-push hook which included a loop over standard
>> input (stdin):
>> ...
>> I bisected using `timeout 3 git push ...` with a local remote to
>> 857f047e (hook: allow overriding the ungroup option, 2025-12-26).
>
> A shot in the dark, but it smells somewhat related to what was
> discussed in this thread?
>
> https://lore.kernel.org/git/87h5spimno.fsf@collabora.com/
I'm 99% certain it's the same bug and root cause.
Chris confirmed the v1 fix worked for git-lfs which is great.
I'm very close to sending v2 which includes the regression tests we
discussed.
Many thanks for reporting, sorry for the breakage and thank you for your
patience!
next prev parent reply other threads:[~2026-01-13 21:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 20:26 [BUG] push: pre-push hook that waits for stdin is slow Kristoffer Haugsbakk
2026-01-13 20:44 ` Junio C Hamano
2026-01-13 21:10 ` Adrian Ratiu [this message]
2026-01-13 23:55 ` Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjixi5hj.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox