From: Andreas Schwab <schwab@linux-m68k.org>
To: "David A. Greene" <greened@obbligato.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 03/13] contrib/subtree: Better Error Handling for add
Date: Fri, 02 Aug 2013 10:19:16 +0200 [thread overview]
Message-ID: <87bo5g5wu3.fsf@igel.home> (raw)
In-Reply-To: <1360064219-28789-4-git-send-email-greened@obbligato.org> (David A. Greene's message of "Tue, 5 Feb 2013 05:36:49 -0600")
"David A. Greene" <greened@obbligato.org> writes:
> elif [ $# -eq 2 ]; then
> - "cmd_add_repository" "$@"
> + git rev-parse -q --verify "$2^{commit}" >/dev/null ||
> + die "'$2' does not refer to a commit"
That doesn't make any sense. $2 is a commit in a remote repository
which hasn't been fetched yet, so it can never be verified against the
local repository.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2013-08-02 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 11:36 Rebased git-subtree changes David A. Greene
2013-02-05 11:36 ` [PATCH 01/13] contrib/subtree: Remove Test Number Comments David A. Greene
2013-02-05 11:36 ` [PATCH 02/13] contrib/subtree: Use %B for Split Subject/Body David A. Greene
2013-02-05 11:36 ` [PATCH 03/13] contrib/subtree: Better Error Handling for add David A. Greene
2013-08-02 8:19 ` Andreas Schwab [this message]
2013-02-05 11:36 ` [PATCH 04/13] contrib/subtree: Fix Synopsis David A. Greene
2013-08-02 8:20 ` Andreas Schwab
2013-02-05 11:36 ` [PATCH 05/13] contrib/subtree: Honor DESTDIR David A. Greene
2013-02-05 11:36 ` [PATCH 06/13] contrib/subtree: Make the Manual Directory if Needed David A. Greene
2013-02-05 11:36 ` [PATCH 07/13] contrib/subtree: Fix whitespaces David A. Greene
2013-02-05 11:36 ` [PATCH 08/13] contrib/subtree: Add vim modeline David A. Greene
2013-02-05 11:36 ` [PATCH 09/13] contrib/subtree: Ignore testing directory David A. Greene
2013-02-05 11:36 ` [PATCH 10/13] contrib/subtree: Code cleaning and refactoring David A. Greene
2013-02-05 11:36 ` [PATCH 11/13] contrib/subtree: Make each test self-contained David A. Greene
2013-02-05 11:36 ` [PATCH 12/13] contrib/subtree: Handle '--prefix' argument with a slash appended David A. Greene
2013-02-05 11:36 ` [PATCH 13/13] contrib/subtree: Remove --annotate David A. Greene
2013-02-05 11:52 ` Rebased git-subtree changes greened
2013-02-05 23:18 ` Junio C Hamano
2013-02-18 20:12 ` greened
-- strict thread matches above, loose matches on Subject: below --
2013-02-05 4:06 Assorted contrib/subtree Patches David A. Greene
2013-02-05 4:06 ` [PATCH 03/13] contrib/subtree: Better Error Handling for add David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo5g5wu3.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=greened@obbligato.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).