From: Alexandre Julliard <julliard@winehq.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David Kågedal" <davidk@lysator.liu.se>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] git.el: Diff only file at point by default
Date: Mon, 25 Aug 2008 11:30:03 +0200 [thread overview]
Message-ID: <87bpzh8msk.fsf@wine.dyndns.org> (raw)
In-Reply-To: <7v3akvw7gz.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 23 Aug 2008 18:02:36 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> David Kågedal <davidk@lysator.liu.se> writes:
>
>> Use prefix (C-u) to diff all marked files instead.
>>
>> Signed-off-by: David Kågedal <davidk@lysator.liu.se>
>> ---
>> contrib/emacs/git.el | 13 +++++++++----
>> 1 files changed, 9 insertions(+), 4 deletions(-)
>>
>> For anyone who has used pcvs (or dsvn) this makes much more sense. The
>
> Looks sensible to me; Alexandre?
Looks OK to me, but I think you should apply the same treatment to all
the other diff functions. Also the documentation string needs a bit more
work.
--
Alexandre Julliard
julliard@winehq.org
next prev parent reply other threads:[~2008-08-25 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 7:58 [PATCH] git.el: Diff only file at point by default David Kågedal
2008-08-24 1:02 ` Junio C Hamano
2008-08-25 9:30 ` Alexandre Julliard [this message]
2008-08-25 13:21 ` David Kågedal
2008-08-26 22:22 ` David Kågedal
2008-08-27 19:36 ` Junio C Hamano
2008-08-30 18:29 ` Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpzh8msk.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).