From: Jeremy Maitin-Shepard <jbms@cmu.edu>
To: Boyd Lynn Gerber <gerberb@zenez.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.
Date: Fri, 06 Jun 2008 15:39:21 -0400 [thread overview]
Message-ID: <87bq2ez72u.fsf@jeremyms.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com> (Boyd Lynn Gerber's message of "Fri, 6 Jun 2008 13:34:03 -0600")
Boyd Lynn Gerber <gerberb@zenez.com> writes:
[snip]
> diff --git a/progress.c b/progress.c
> index d19f80c..11a0841 100644
> --- a/progress.c
> +++ b/progress.c
> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const
> char *msg)
> *p_progress = NULL;
> if (progress->last_value != -1) {
> /* Force the last update */
> - char buf[strlen(msg) + 5];
> + /* char buf[strlen(msg) + 5]; */
> + char *buf = malloc (strlen(msg) + 5 );
This change will result in the allocated memory being leaked, which is
probably not correct. Perhaps change it to alloca instead.
--
Jeremy Maitin-Shepard
next prev parent reply other threads:[~2008-06-06 19:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 19:34 [PATCH] This patch is to allow 12 different OS's to compile and run git Boyd Lynn Gerber
2008-06-06 19:39 ` Jeremy Maitin-Shepard [this message]
2008-06-06 20:02 ` Boyd Lynn Gerber
2008-06-06 20:15 ` Stephan Beyer
2008-06-06 20:28 ` Linus Torvalds
2008-06-06 20:44 ` Boyd Lynn Gerber
2008-06-06 22:16 ` Brandon Casey
2008-06-06 23:08 ` Junio C Hamano
2008-06-06 23:23 ` Boyd Lynn Gerber
2008-06-07 0:38 ` [PATCH] 0002 " Boyd Lynn Gerber
2008-06-07 0:47 ` Daniel Barkalow
2008-06-07 1:25 ` [PATCH] 0003 " Boyd Lynn Gerber
2008-06-07 2:12 ` Junio C Hamano
2008-06-07 2:40 ` Boyd Lynn Gerber
2008-06-07 3:40 ` Daniel Barkalow
2008-06-08 3:46 ` Boyd Lynn Gerber
2008-06-08 7:45 ` Junio C Hamano
2008-06-08 16:57 ` [PATCH] progress.c: avoid use of dynamic-sized array Boyd Lynn Gerber
2008-06-08 17:07 ` [PATCH] Port to 12 other Platforms Boyd Lynn Gerber
2008-06-08 3:50 ` [PATCH] 0004 This patch is to allow 12 different OS's to compile and run git Boyd Lynn Gerber
2008-06-08 7:22 ` Boyd Lynn Gerber
2008-06-06 19:46 ` [PATCH] " Thomas Harning
2008-06-06 22:58 ` Daniel Barkalow
2008-06-06 23:17 ` Boyd Lynn Gerber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bq2ez72u.fsf@jeremyms.com \
--to=jbms@cmu.edu \
--cc=gerberb@zenez.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).