From: Thomas Rast <trast@student.ethz.ch>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
<git@vger.kernel.org>
Subject: Re: [PATCH] gitignore: warn about pointless syntax
Date: Tue, 10 Jan 2012 10:44:58 +0100 [thread overview]
Message-ID: <87d3arnb6t.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <alpine.LNX.2.01.1201100639340.11534@frira.zrqbmnf.qr> (Jan Engelhardt's message of "Tue, 10 Jan 2012 06:42:11 +0100")
Jan Engelhardt <jengelh@medozas.de> writes:
>
> As I see it, foo/**/*.o for example is equal to placing "*.o" in
> foo/.gitignore, so the feature is already implemented, just not
> through the syntax people falsely assume it is. And that is the
> reason for wanting to output a warning. If it was me, I'd even make
> it use error(),
No, please don't even think about it. Having an error() there would
mean that git would be essentially useless in repositories that have
this mistake, and the user may not be in a position to fix the
repository!
(He could drag along a local change to that effect, which is highly
annoying if the repository is otherwise read-only for him.)
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-01-10 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 15:40 gitignore warn about ** submission Jan Engelhardt
2012-01-09 15:40 ` [PATCH] gitignore: warn about pointless syntax Jan Engelhardt
2012-01-09 16:28 ` Jeff King
2012-01-09 19:43 ` Junio C Hamano
2012-01-09 22:33 ` Jeff King
2012-01-10 5:42 ` Jan Engelhardt
2012-01-10 6:01 ` Junio C Hamano
2012-01-10 7:01 ` Jan Engelhardt
2012-01-10 7:02 ` Jan Engelhardt
2012-01-10 9:44 ` Thomas Rast [this message]
2012-01-10 18:51 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 11:34 [patch] " Jan Engelhardt
2012-01-09 13:44 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3arnb6t.fsf@thomas.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jengelh@medozas.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).