git-svn dcommit failure

git-svn dcommit failure

[Florian Weimer]

I suddenly can't run dcommit on some of my working copies.  The change
I'm trying to push is pretty innocuous: just a single-line change (no
new file or directory).  dcommit fails with: "Network connection
closed unexpectedly: Connection closed unexpectedly at
/usr/bin/git-svn line 405".  I've looked at the data that is received
over SSH, and it looks pretty regular to me (that is, no interspersed
error message or something like that).

Is there any option to generate more debug output?

This with git-svn 1.5.1.4-2 on something that is quite close to Debian
etch.

Re: git-svn dcommit failure

[Florian Weimer]

* Florian Weimer:

> This with git-svn 1.5.1.4-2 on something that is quite close to Debian
> etch.

Same issue with 1.5.2~rc3-2.

Re: git-svn dcommit failure

[Florian Weimer]

* Pierre Habouzit:

> On Tue, May 29, 2007 at 11:35:10AM +0200, Florian Weimer wrote:
>> * Florian Weimer:
>> 
>> > This with git-svn 1.5.1.4-2 on something that is quite close to Debian
>> > etch.
>> 
>> Same issue with 1.5.2~rc3-2.
>
>   Are you using ControlMaster in your ssh setup in auto/autoask mode? (I
> assume your repository is svn+ssh). If yes, then you *have* to start a
> persistent ssh connection before you do anything else:

No.  It's svn+ssh (with a custom connect script), but without the
controlchan extension.  Subversion works fine and lets me commit
changes.

After manually committing the offending changes via Subversion, I
git-svn has begun to work again, too (but I haven't yet tried to
change the same files).

Re: git-svn dcommit failure

[Eric Wong]

Florian Weimer <fw@deneb.enyo.de> wrote:
> * Pierre Habouzit:
> 
> > On Tue, May 29, 2007 at 11:35:10AM +0200, Florian Weimer wrote:
> >> * Florian Weimer:
> >> 
> >> > This with git-svn 1.5.1.4-2 on something that is quite close to Debian
> >> > etch.
> >> 
> >> Same issue with 1.5.2~rc3-2.
> >
> >   Are you using ControlMaster in your ssh setup in auto/autoask mode? (I
> > assume your repository is svn+ssh). If yes, then you *have* to start a
> > persistent ssh connection before you do anything else:
> 
> No.  It's svn+ssh (with a custom connect script), but without the
> controlchan extension.  Subversion works fine and lets me commit
> changes.
> 
> After manually committing the offending changes via Subversion, I
> git-svn has begun to work again, too (but I haven't yet tried to
> change the same files).

Would upgrading to 1.5.2 final have helped?

Looking at 6442754d6cc0056cf5b69b43d218f8b6d317e7f5 (which was made
right before 1.5.2 final), the bug it fixed could've actually affected
modification-only commits, too.

If it's a public repository, could I look at the changeset that was
giving you trouble, and the [svn-remote] section of your .git/config
file?  Thanks.

-- 
Eric Wong

Re: git-svn dcommit failure

[Florian Weimer]

* Eric Wong:

>> After manually committing the offending changes via Subversion, I
>> git-svn has begun to work again, too (but I haven't yet tried to
>> change the same files).
>
> Would upgrading to 1.5.2 final have helped?

I've upgraded to this version, but since it's not exactly trivial for
me to test this on the Subversion side, it'll take some time until I
can be confident that the bug was indeed fixed in the
6442754d6cc0056cf5b69b43d218f8b6d317e7f5 revision.

Is there some kind of magic environment variable I could set to get
tracing information?  If such bugs turn up, I'd try to debug them on
my own and submit a fix, or at least a reproduction recipe.  (The
repository itself may contain personally identifiable information in
test cases and hence, cannot be shared.)

Re: git-svn dcommit failure

[Eric Wong]

Florian Weimer <fw@deneb.enyo.de> wrote:
> * Eric Wong:
> 
> >> After manually committing the offending changes via Subversion, I
> >> git-svn has begun to work again, too (but I haven't yet tried to
> >> change the same files).
> >
> > Would upgrading to 1.5.2 final have helped?
> 
> I've upgraded to this version, but since it's not exactly trivial for
> me to test this on the Subversion side, it'll take some time until I
> can be confident that the bug was indeed fixed in the
> 6442754d6cc0056cf5b69b43d218f8b6d317e7f5 revision.
> 
> Is there some kind of magic environment variable I could set to get
> tracing information?

Nope.  I usually strace protocol or put print statements all over the
code :x

> If such bugs turn up, I'd try to debug them on
> my own and submit a fix, or at least a reproduction recipe.  (The
> repository itself may contain personally identifiable information in
> test cases and hence, cannot be shared.)

Was the commit modifying a file that was just one directory deep from
the project you were working on?

-- 
Eric Wong

Re: git-svn dcommit failure

[Florian Weimer]

* Eric Wong:

>> If such bugs turn up, I'd try to debug them on
>> my own and submit a fix, or at least a reproduction recipe.  (The
>> repository itself may contain personally identifiable information in
>> test cases and hence, cannot be shared.)
>
> Was the commit modifying a file that was just one directory deep from
> the project you were working on?

Yes, it was.