From: Kyle Meyer <kyle@kyleam.com>
To: Simon Richter <Simon.Richter@hogyros.de>
Cc: git@vger.kernel.org
Subject: Re: Regression: cannot edit after intent-to-add
Date: Tue, 03 Nov 2020 12:44:23 -0500 [thread overview]
Message-ID: <87eelamj2g.fsf@kyleam.com> (raw)
In-Reply-To: <20201103171618.GA28810@psi5.com>
Simon Richter writes:
> git-add -p now shows me both lines as added, but does not allow me to edit.
> If I want to create an intermediate commit adding just one of the lines, I
> have to edit the actual file.
>
> This used to work in older versions, as I remember using this technique for
> a while and recommending it to others.
>
> Before I do a deep-dive into a codebase I haven't looked at in years: can
> this be re-added easily?
Which version of git are you using? I think this was already fixed by
75a009dc29 (add -p: fix editing of intent-to-add paths, 2020-09-09),
which was included in v2.29.0.
https://lore.kernel.org/git/pull.731.git.1599659932391.gitgitgadget@gmail.com/
prev parent reply other threads:[~2020-11-03 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 17:16 Regression: cannot edit after intent-to-add Simon Richter
2020-11-03 17:44 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eelamj2g.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=Simon.Richter@hogyros.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).