From: Ralf Thielow <ralf.thielow@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] string_list: use string-list API in unsorted_string_list_lookup()
Date: Mon, 25 Apr 2016 19:35:41 +0200 [thread overview]
Message-ID: <87eg9t8uc2.fsf@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1604240901570.2896@virtualbox> (Johannes Schindelin's message of "Sun, 24 Apr 2016 09:06:12 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> - for (i = 0; i < list->nr; i++)
>> - if (!cmp(string, list->items[i].string))
>> - return list->items + i;
>> + for_each_string_list_item(item, list) {
>> + if (!cmp(string, item->string))
>> + return item;
>> + }
>> return NULL;
>
> If you drop the extra curly braces (thereby matching Git's coding style as
> an additional bonus), at least the patch won't increase the number of
> lines.
>
Oops. I'll send a new version of the patch without these
extra curly braces.
Thanks!
> In any case, I like the simplification of the code.
>
> Ciao,
> Dscho
next prev parent reply other threads:[~2016-04-25 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 17:35 [PATCH] string_list: use string-list API in unsorted_string_list_lookup() Ralf Thielow
2016-04-24 7:06 ` Johannes Schindelin
2016-04-25 17:35 ` Ralf Thielow [this message]
2016-04-25 17:40 ` [PATCH v2] " Ralf Thielow
2016-04-25 17:47 ` Stefan Beller
2016-04-26 15:42 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg9t8uc2.fsf@gmail.com \
--to=ralf.thielow@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).