git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Jeff King" <peff@peff.net>, "Junio C Hamano" <gitster@pobox.com>,
	"Thomas Rast" <trast@student.ethz.ch>,
	"Carlos Martín Nieto" <cmn@elego.de>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	git@vger.kernel.org
Subject: Re: "docs: stop using asciidoc no-inline-literal" breaks asciidoc 8.2.5
Date: Tue, 29 May 2012 14:03:39 +0200	[thread overview]
Message-ID: <87ehq3mbxg.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <CACBZZX7Y-NTzRP1KYy=eEHTsLHTrzxGms61anXSHVbyCSPgurw@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 29 May 2012 12:19:56 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Jeff King's 6cf378f0cbe7c7f944637892caeb9058c90a185a broke my Git
> build on CentOS 5.5. The patch suggests that it only breaks
> compatibility with asciidoc 7 but that isn't actually the case.

The commit message of 6cf378f0 is not correct in that respect.  My
ancient 71c020c5 has the right numbers: asciidoc 8.4.1 is the one that
introduced the new inline-literal behavior.  Based on my little survey
in

  http://thread.gmane.org/gmane.comp.version-control.git/191738/focus=191790

we decided that "nobody" really uses such an old asciidoc any more.
Evidently you are a counterexample.

> I suggest just ejecting this patch and trying again, these RedHat
> systems are still used in a lot of environments, especially by various
> companies.

Do you/they have to *build* the docs, as opposed to using the prebuilt
ones coming from Junio?  Perhaps we can make it so 'make man' refuses to
run if asciidoc is too old, and give a message to the effect that you
should 'make quick-install-man' instead.

Otherwise we'll be working around the f{asterisk}{asterisk}{asterisk}ing
quoting rules for years to come.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-05-29 12:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-29 10:19 "docs: stop using asciidoc no-inline-literal" breaks asciidoc 8.2.5 Ævar Arnfjörð Bjarmason
2012-05-29 12:03 ` Thomas Rast [this message]
2012-05-29 12:31   ` Ævar Arnfjörð Bjarmason
2012-05-29 19:45     ` Junio C Hamano
2012-05-29 22:01       ` Jeff King
2012-05-29 21:56     ` Jeff King
2012-05-29 22:05       ` Dennis Kaarsemaker
2012-05-29 22:42       ` Ævar Arnfjörð Bjarmason
2012-05-29 22:51         ` Ævar Arnfjörð Bjarmason
2012-05-30  8:51         ` Jeff King
2012-05-30  9:02           ` Matthieu Moy
2012-05-30 10:17       ` [PATCH 0/3] docs: asciidoc version tweaks Jeff King
2012-05-30 10:18         ` [PATCH 1/3] INSTALL: update asciidoc recommendation Jeff King
2012-05-30 10:22         ` [PATCH 2/3] docs: drop asciidoc7compatible flag Jeff King
2012-05-30 10:22         ` [PATCH 3/3] docs: drop antique comment from Makefile Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehq3mbxg.fsf@thomas.inf.ethz.ch \
    --to=trast@inf.ethz.ch \
    --cc=Matthieu.Moy@imag.fr \
    --cc=avarab@gmail.com \
    --cc=cmn@elego.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).