From: Thomas Rast <trast@inf.ethz.ch>
To: Jared Hance <jaredhance@gmail.com>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>
Subject: Re: [PATCH v2 3/3] Add threaded versions of functions in symlinks.c.
Date: Mon, 5 Mar 2012 12:00:07 +0100 [thread overview]
Message-ID: <87eht7pb2g.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <e86eea36804fcf764ba9c3940a3cceb13b5a2c4b.1330785363.git.jaredhance@gmail.com> (Jared Hance's message of "Sat, 3 Mar 2012 09:40:30 -0500")
Jared Hance <jaredhance@gmail.com> writes:
> int check_leading_path(const char *name, int len)
> {
> - struct cache_def *cache = &default_cache; /* FIXME */
> + return threaded_check_leading_path(&default_cache, name, len);
> +}
This hunk is indent-by-space damaged.
Otherwise the patch looks good to me.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2012-03-05 11:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 2:31 [PATCH 0/3] Fix some documented fixmes Jared Hance
2012-03-03 2:31 ` [PATCH 1/3] Use startup_info->prefix rather than prefix Jared Hance
2012-03-03 7:30 ` Junio C Hamano
2012-03-03 9:50 ` Nguyen Thai Ngoc Duy
2012-03-03 21:44 ` Junio C Hamano
2012-03-03 23:23 ` Jared Hance
2012-03-03 2:31 ` [PATCH 2/3] Fix memory leak in apply_patch in apply.c Jared Hance
2012-03-03 7:41 ` Junio C Hamano
2012-03-03 2:31 ` [PATCH 3/3] Add threaded versions of functions in symlinks.c Jared Hance
2012-03-03 7:55 ` Junio C Hamano
2012-03-03 14:40 ` [PATCH v2 0/3] Fix a few documents fixmes Jared Hance
2012-03-03 14:40 ` [PATCH v2 1/3] Use startup_info->prefix rather than prefix Jared Hance
2012-03-03 14:47 ` Jeff Epler
2012-03-03 14:40 ` [PATCH v2 2/3] Fix memory leak in apply_patch in apply.c Jared Hance
2012-03-03 15:05 ` Jared Hance
2012-03-03 21:51 ` Junio C Hamano
2012-03-03 14:40 ` [PATCH v2 3/3] Add threaded versions of functions in symlinks.c Jared Hance
2012-03-05 11:00 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eht7pb2g.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaredhance@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).