From: Nix <nix@esperi.org.uk>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Clemens Buchacher <drizzd@aon.at>,
Sverre Rabbelier <srabbelier@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/2] Support sizes >=2G in various config options accepting 'g' sizes.
Date: Tue, 06 Sep 2011 12:17:39 +0100 [thread overview]
Message-ID: <87ehztkjho.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <4E65F842.7080601@viscovery.net> (Johannes Sixt's message of "Tue, 06 Sep 2011 12:38:58 +0200")
On 6 Sep 2011, Johannes Sixt stated:
> Am 9/6/2011 12:25, schrieb Nix:
>> OK, I'll add range checking support then!
>
> Don't forget to follow this advice noted on the POSIX page
> (http://pubs.opengroup.org/onlinepubs/9699919799/functions/strtol.html):
>
> Since 0, {LONG_MIN} or {LLONG_MIN}, and {LONG_MAX} or {LLONG_MAX} are
> returned on error and are also valid returns on success, an application
> wishing to check for error situations should set errno to 0, then call
> strtol() or strtoll(), then check errno.
Oh, I've fallen into *that* trap before with math functions setting
ERANGE/EDOM. Thanks for the reminder :)
--
NULL && (void)
next prev parent reply other threads:[~2011-09-06 11:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 11:45 [PATCH 1/2] Add strtoimax() compatibility function Nix
2011-09-05 11:45 ` [PATCH 2/2] Support sizes >=2G in various config options accepting 'g' sizes Nix
2011-09-05 13:49 ` Sverre Rabbelier
2011-09-05 13:56 ` Nix
2011-09-06 7:44 ` Clemens Buchacher
2011-09-06 9:13 ` Nix
2011-09-06 10:22 ` Johannes Sixt
2011-09-06 10:25 ` Nix
2011-09-06 10:38 ` Johannes Sixt
2011-09-06 11:17 ` Nix [this message]
2011-09-06 6:19 ` [PATCH 1/2] Add strtoimax() compatibility function Junio C Hamano
2011-09-06 9:14 ` Nix
-- strict thread matches above, loose matches on Subject: below --
2011-11-02 15:46 [PATCH 0/2] Support sizes >=2G in various config options, v2 Nick Alcock
2011-11-02 15:46 ` [PATCH 2/2] Support sizes >=2G in various config options accepting 'g' sizes Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehztkjho.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).