git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Julliard <julliard@winehq.org>
To: "Ismail Dönmez" <ismail@pardus.org.tr>
Cc: Junio C Hamano <junkio@cox.net>,
	git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: use decode_utf8 directly
Date: Fri, 01 Jun 2007 18:51:27 +0200	[thread overview]
Message-ID: <87ejkvty7k.fsf@wine.dyndns.org> (raw)
In-Reply-To: <200706011650.10650.ismail@pardus.org.tr> (Ismail Dönmez's message of "Fri\, 1 Jun 2007 16\:50\:09 +0300")

Ismail Dönmez <ismail@pardus.org.tr> writes:

> Sorry but thats too old. Of course I am not the maintainer of GIT so its not 
> for me to decide but well as David Woodhouse puts it, please join us in 21st 
> century and start using UTF-8.

That's not very helpful. There can be many valid reasons for not using
utf-8, in our case compatibility with Windows tools is the main
reason. And even if we were to convert all our files today, it
wouldn't help when browsing older versions.

I'm not asking gitweb to magically guess the encoding of the files,
I'm happy with it replacing invalid sequences with some substitution
char, like it did before 1.5.2. But now it is deleting whole lines
from the diff, without any indication that something went wrong.
That's not an improvement IMNSHO.

-- 
Alexandre Julliard
julliard@winehq.org

  reply	other threads:[~2007-06-01 16:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 14:05 [PATCH] gitweb: use decode_utf8 directly Ismail Dönmez
2007-04-27  8:55 ` Ismail Dönmez
2007-04-27  9:07   ` Junio C Hamano
2007-04-27  9:22     ` Ismail Dönmez
2007-04-27 19:29       ` Junio C Hamano
2007-05-01 21:12         ` Ismail Dönmez
2007-05-01 21:39           ` Junio C Hamano
2007-05-01 21:44             ` Ismail Dönmez
2007-05-01 21:48               ` Ismail Dönmez
2007-05-03 19:22             ` Ismail Dönmez
2007-05-03 19:26               ` Junio C Hamano
2007-06-01 13:45                 ` Alexandre Julliard
2007-06-01 13:50                   ` Ismail Dönmez
2007-06-01 16:51                     ` Alexandre Julliard [this message]
2007-06-01 19:44                   ` Junio C Hamano
2007-06-01 19:47                     ` Ismail Dönmez
2007-06-01 20:00                       ` Junio C Hamano
2007-06-01 20:08                         ` Ismail Dönmez
2007-06-03 22:06                           ` Junio C Hamano
2007-06-03 22:13                             ` Ismail Dönmez
2007-06-02  8:22                   ` Jakub Narebski
  -- strict thread matches above, loose matches on Subject: below --
2007-06-01 16:13 Martin Koegler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ejkvty7k.fsf@wine.dyndns.org \
    --to=julliard@winehq.org \
    --cc=git@vger.kernel.org \
    --cc=ismail@pardus.org.tr \
    --cc=jnareb@gmail.com \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).