From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>,
rsbecker@nexbridge.com, Jeff King <peff@peff.net>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] reftable: fix tests being broken by NFS' delete-after-close semantics
Date: Fri, 22 Mar 2024 16:15:12 +0100 [thread overview]
Message-ID: <87frwiuwlb.fsf@to1.studio> (raw)
In-Reply-To: <8ac5e94a3930cdd2aee9ea86acda3155674b635c.1711035529.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> Fix this bug by skipping over any files that start with a leading dot
> when counting files. While we could explicitly check for a prefix of
> ".nfs", other network file systems like SMB for example do the same
> trickery but with a ".smb" prefix. In any case though, this loosening of
> the assertion should be fine given that the reftable library would never
> write files with leading dots by itself.
I'm fully supportive of this, as this will also fix any issues possibly
caused by .DS_Store files created by Finder on macOS, although it's very
unlikely they will be created in these tests.
--
Toon
prev parent reply other threads:[~2024-03-22 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 15:10 t0032 fails on NFS mounts Chuck Lever
2024-03-12 17:11 ` rsbecker
2024-03-21 15:50 ` Patrick Steinhardt
2024-03-13 7:20 ` Jeff King
2024-03-15 0:35 ` Patrick Steinhardt
2024-03-15 15:41 ` Junio C Hamano
2024-03-21 15:14 ` Patrick Steinhardt
2024-03-21 15:39 ` [PATCH] reftable: fix tests being broken by NFS' delete-after-close semantics Patrick Steinhardt
2024-03-21 17:35 ` Junio C Hamano
2024-03-22 15:15 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frwiuwlb.fsf@to1.studio \
--to=toon@iotcl.com \
--cc=chuck.lever@oracle.com \
--cc=git@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).