From: Thomas Rast <trast@inf.ethz.ch>
To: "Nelson Benítez León" <nbenitezl@gmail.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>, <git@vger.kernel.org>
Subject: Re: [PATCH] Improve http proxy support
Date: Wed, 22 Feb 2012 17:43:25 +0100 [thread overview]
Message-ID: <87fwe2x1hu.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <vpqd397x8fc.fsf@bauges.imag.fr> (Matthieu Moy's message of "Wed, 22 Feb 2012 15:13:43 +0100")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Nelson Benítez León <nbenitezl@gmail.com> writes:
>
>> Hi, my initial motivation for this patch was to add NTLM proxy
>> authentication [...]
>
> That sounds interesting, but please read Documentation/SubmittingPatches
> in Git's tree. The formatting of your email is wrong (giving more work
> for your maintainer) and you need to sign-off your patch to allow your
> code to be legally included.
Judging from the message, it also conflates three changes into one
patch. Don't do that.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-02-22 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 14:04 [PATCH] Improve http proxy support Nelson Benítez León
2012-02-22 14:13 ` Matthieu Moy
2012-02-22 16:43 ` Thomas Rast [this message]
2012-02-23 12:20 ` Nelson Benítez León
2012-02-23 12:52 ` [PATCH] README: point to Documentation/SubmittingPatches Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwe2x1hu.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=nbenitezl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).