* [BUG] git-am and git-submodule rely on $PATH to find perl
@ 2011-07-20 22:35 Peter Simons
2011-07-22 22:40 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Peter Simons @ 2011-07-20 22:35 UTC (permalink / raw)
To: git
Both scripts run perl without any path, i.e. they don't use the
$PERL_PATH that was passed at build time.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] git-am and git-submodule rely on $PATH to find perl
2011-07-20 22:35 [BUG] git-am and git-submodule rely on $PATH to find perl Peter Simons
@ 2011-07-22 22:40 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2011-07-22 22:40 UTC (permalink / raw)
To: Peter Simons; +Cc: git
On Thu, Jul 21, 2011 at 12:35:56AM +0200, Peter Simons wrote:
> Both scripts run perl without any path, i.e. they don't use the
> $PERL_PATH that was passed at build time.
This isn't exactly a bug. The rule we usually follow in git is that you
can use "perl" in the PATH when you are doing simple awk-like things
that any version of perl should do. But you must use PERL_PATH for
#!-lines (because we can't do PATH lookup there), or for any non-trivial
script.
That being said, I don't see any downside to using PERL_PATH. The
Makefile tweaks would be pretty minimal. Want to work up a patch?
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-22 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20 22:35 [BUG] git-am and git-submodule rely on $PATH to find perl Peter Simons
2011-07-22 22:40 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).