From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yasushi SHOJI <yashi@atmark-techno.com>
Subject: Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain
Date: Tue, 29 Jan 2008 14:45:56 +0900
Message-ID: <87fxwhi3qj.wl@mail2.atmark-techno.com>
References: <87ve5dicih.wl@mail2.atmark-techno.com>
	<7vir1dqjg0.fsf@gitster.siamese.dyndns.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Cc: git@vger.kernel.org
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Tue Jan 29 06:46:33 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JJjIk-00017q-1s
	for gcvg-git-2@gmane.org; Tue, 29 Jan 2008 06:46:30 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752552AbYA2Fp7 (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Tue, 29 Jan 2008 00:45:59 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751841AbYA2Fp7
	(ORCPT <rfc822;git-outgoing>); Tue, 29 Jan 2008 00:45:59 -0500
Received: from mail2.atmark-techno.com ([210.191.215.173]:49723 "EHLO
	mail2.atmark-techno.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750837AbYA2Fp6 (ORCPT <rfc822;git@vger.kernel.org>);
	Tue, 29 Jan 2008 00:45:58 -0500
Received: from wat.atmark-techno.com.atmark-techno.com (dns1.atmark-techno.com [210.191.215.170])
	by mail2.atmark-techno.com (Postfix) with ESMTP id A3E59584C7;
	Tue, 29 Jan 2008 14:45:56 +0900 (JST)
In-Reply-To: <7vir1dqjg0.fsf@gitster.siamese.dyndns.org>
User-Agent: Wanderlust/2.14.0
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/71949>

At Mon, 28 Jan 2008 21:39:27 -0800,
Junio C Hamano wrote:
> 
> Yasushi SHOJI <yashi@atmark-techno.com> writes:
> 
> > This patch effectively revert the commitdiff plain part of the commit
> >
> > 	59b9f61a3f76762dc975e99cc05335a3b97ad1f9
> >
> > which converted from print to here-doc. but it doesn't
> > explain why in the commit log.
> 
> I think the patch makes sense but the above is misleading.  Read
> it again.
> 
> Doesn't it sound like you are accusing that 59b9f61a introduced
> a regression when it converted existsing "print utf8()" to
> "print <<here-doc" without saying that is what it is doing?

sorry about my stupid english.  What I meant was that because commit
log doesn't say _why_ it changed to here-doc, I couldn't be sure it
was ok to overwrite the change introduced by the commit 59b9f61a3.

IOW, I was tring to ask, "is it ok to revert back to print?"
-- 
         yashi