From: Alexandre Julliard <julliard@winehq.org>
To: =?utf-8?q?R=C3=A9mi=20Vanicat?= <vanicat@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Adding menu for Emacs git.el
Date: Sun, 02 Dec 2007 19:42:31 +0100 [thread overview]
Message-ID: <87fxylos4o.fsf@wine.dyndns.org> (raw)
In-Reply-To: <87mysvfr7e.dlv@vanicat.homelinux.org> (utf's message of "Fri, 30 Nov 2007 20:29:08 +0100")
"=?utf-8?q?R=C3=A9mi=20Vanicat?=" <vanicat@debian.org>, Remi Vanicat
<vanicat@debian.org> writes:
> Adding three menu to the git-status-mode of git.el : One for marking
> and unmarking, one for every thing you need when you have a conflict,
> and a last one for all the rest.
>
> Signed-off-by: Rémi Vanicat <vanicat@debian.org>
It looks good to me. A couple of minor details:
> + ["Interctive Diff File" git-diff-file-idiff t]
There's a typo here.
> + ["Show Uptodate" git-toggle-show-uptodate :style toggle :selected git-show-uptodate]
> + ["Toggle Show Ignored" git-toggle-show-ignored :style toggle :selected git-show-ignored]
> + ["Toggle Show Unknown" git-toggle-show-unknown :style toggle :selected git-show-unknown]))
I'd get rid of 'Toggle' on the last two for consistency.
BTW do you have a copyright assignment for Emacs?
--
Alexandre Julliard
julliard@winehq.org
next prev parent reply other threads:[~2007-12-02 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 19:29 [PATCH] Adding menu for Emacs git.el =?utf-8?q?R=C3=A9mi=20Vanicat?=, Remi Vanicat
2007-12-02 18:42 ` Alexandre Julliard [this message]
2007-12-03 6:03 ` Remi Vanicat
2007-12-03 17:13 ` Alexandre Julliard
2007-12-03 21:06 ` [PATCH v3] Adding menus " Remi Vanicat
2007-12-11 6:36 ` [PATCH] Adding menu " Junio C Hamano
2007-12-11 13:02 ` Alexandre Julliard
2007-12-11 16:27 ` Remi Vanicat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxylos4o.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=git@vger.kernel.org \
--cc=vanicat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).