From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: SunCC doesn't compile v2.32.0-rc* anymore (was "Re: [PATCH 2/3] t/helper/test-bitmap.c: initial commit")
Date: Wed, 26 May 2021 20:30:49 +0200 [thread overview]
Message-ID: <87h7ipmjkw.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <ec974bb0c85bcde00d45e983d701c538488550a6.1617240723.git.me@ttaylorr.com>
On Wed, Mar 31 2021, Taylor Blau wrote:
> Add a new 'bitmap' test-tool which can be used to list the commits that
> have received bitmaps.
> [...]
> @@ -0,0 +1,24 @@
> +#include "test-tool.h"
> +#include "cache.h"
> +#include "pack-bitmap.h"
Since this commit SunCC (on Solaris) refuses to compile git, a new bug
in v2.32.0-rc*.
It's because it can't find the oe_get_size_slow symbol, you include
pack-bitmap.h, which in turn includes pack-objects.h. That file
references oe_get_size_slow, but it's only defined in
builtin/pack-objects.c.
That looseness of definitions far pre-dates v2.32.0, but I suspect we
got away with it due to builtins including everything (or something)
anyway, and that this is the first test-tool usage.
next prev parent reply other threads:[~2021-05-26 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 1:32 [PATCH 0/3] pack-objects: introduce pack.preferBitmapTips Taylor Blau
2021-04-01 1:32 ` [PATCH 1/3] pack-bitmap: add 'test_bitmap_commits()' helper Taylor Blau
2021-04-01 1:32 ` [PATCH 2/3] t/helper/test-bitmap.c: initial commit Taylor Blau
2021-05-26 18:30 ` Ævar Arnfjörð Bjarmason [this message]
2021-05-26 18:44 ` SunCC doesn't compile v2.32.0-rc* anymore (was "Re: [PATCH 2/3] t/helper/test-bitmap.c: initial commit") Taylor Blau
2021-05-26 21:10 ` Ævar Arnfjörð Bjarmason
2021-05-27 0:52 ` [PATCH] pack-objects: move builtin-only code to its own header Ævar Arnfjörð Bjarmason
2021-05-27 1:30 ` Junio C Hamano
2021-05-27 2:40 ` Junio C Hamano
2021-05-27 3:14 ` Junio C Hamano
2021-05-27 12:51 ` Ævar Arnfjörð Bjarmason
2021-04-01 1:32 ` [PATCH 3/3] builtin/pack-objects.c: respect 'pack.preferBitmapTips' Taylor Blau
2021-04-01 13:05 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7ipmjkw.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).