From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Loganaden Velvindron <logan@hackers.mu>,
git@vger.kernel.org, Daniel Stenberg <daniel@haxx.se>
Subject: Re: [PATCH v2] Allow use of TLS 1.3
Date: Fri, 23 Mar 2018 23:28:54 +0100 [thread overview]
Message-ID: <87h8p6xw7t.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqy3iih2xi.fsf@gitster-ct.c.googlers.com>
On Fri, Mar 23 2018, Junio C. Hamano wrote:
>> @@ -62,6 +62,9 @@ static struct {
>> { "tlsv1.1", CURL_SSLVERSION_TLSv1_1 },
>> { "tlsv1.2", CURL_SSLVERSION_TLSv1_2 },
>> #endif
>> +#ifdef CURL_SSLVERSION_TLSv1_3
>> + { "tlsv1.3", CURL_SSLVERSION_TLSv1_3 }
>> +#endif
>> };
>
> It seems to me that
>
> https://github.com/curl/curl/blob/master/include/curl/curl.h#L1956
>
> tells me that this #ifdef would not work. Did you test it with the
> "test not version but feature" change you made at the last minute?
>
> I know it is not your fault but is Ævar's, but you're responsible
> for double-checking what you are told on the internet ;-)
Yeah I should add some "I haven't actually tried this, but what do you
think about this?" disclaimer.
But it's not a good sign that we have a v2 with an ifdef that'll never
be true, indicating that it wasn't tested against TLSv1.3. Is there some
way we could check for this in our test suite?
next prev parent reply other threads:[~2018-03-23 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 19:34 [PATCH v2] Allow use of TLS 1.3 Loganaden Velvindron
2018-03-23 21:47 ` Daniel Stenberg
2018-03-23 22:04 ` Junio C Hamano
2018-03-24 7:52 ` Loganaden Velvindron
2018-03-24 4:21 ` Loganaden Velvindron
2018-03-24 4:31 ` Loganaden Velvindron
2018-03-24 5:43 ` Loganaden Velvindron
2018-03-23 21:55 ` Junio C Hamano
2018-03-23 22:28 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-24 4:23 ` Loganaden Velvindron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8p6xw7t.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=logan@hackers.mu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).