From: Thomas Rast <trast@student.ethz.ch>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jeff King <peff@peff.net>, <git@vger.kernel.org>,
Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>,
Brandon Casey <drafnel@gmail.com>,
Philip Oakley <philipoakley@iee.org>
Subject: Re: [PATCHv2 2/2] attr: drop C/C++ default extension mapping
Date: Mon, 19 Dec 2011 21:51:08 +0100 [thread overview]
Message-ID: <87hb0wnv43.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <20111219181003.GB12200@elie.hsd1.il.comcast.net> (Jonathan Nieder's message of "Mon, 19 Dec 2011 12:10:03 -0600")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Jeff King wrote:
>
>> But when you think about it, if our funcname pattern is bad, shouldn't
>> preventing (2) be the right thing? That is, if our funcname pattern is
>> really worse than the default language-agnostic match, wouldn't we be
>> doing everybody a service to simply remove the builtin
>> diff.cpp.xfuncname pattern?
>
> I don't see why. Anyone who has set "diff=cpp" either likes suffering
> (maybe they are hoping to improve the pattern) or is working with a
> codebase for which the current pattern works better than the default
> behavior (maybe their codebase has a lot of goto labels aligned at
> column zero). So removing the funcname pattern can only hurt them.
FWIW, the funcname pattern is not the only feature of the diff
attributes. I set it mainly to get the built-in --word-diff split
regexes.
I agree with Peff's patches though, until the cpp pattern improves, we
should not turn them on by default.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2011-12-19 20:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 11:00 [PATCH] attr: map builtin userdiff drivers to well-known extensions Jeff King
2011-12-16 14:00 ` Johannes Sixt
2011-12-16 17:01 ` Junio C Hamano
2011-12-16 19:21 ` Jeff King
2011-12-16 19:30 ` Jeff King
2011-12-16 19:33 ` Junio C Hamano
2011-12-17 1:17 ` Jeff King
2011-12-16 22:05 ` Johannes Sixt
2011-12-17 1:21 ` Jeff King
2011-12-17 3:38 ` Jonathan Nieder
2011-12-19 15:49 ` [PATCHv2 1/2] " Jeff King
2011-12-19 18:07 ` Jonathan Nieder
2011-12-19 18:55 ` Jeff King
2011-12-22 1:47 ` Ævar Arnfjörð Bjarmason
2011-12-19 15:57 ` [PATCHv2 2/2] attr: drop C/C++ default extension mapping Jeff King
2011-12-19 18:10 ` Jonathan Nieder
2011-12-19 20:51 ` Thomas Rast [this message]
2011-12-19 20:52 ` [PATCH] t4018: introduce test cases for the internal hunk header patterns Brandon Casey
2011-12-19 21:53 ` [PATCH] t4018: add a few more test cases for cpp hunk header matching Brandon Casey
2011-12-19 22:37 ` [PATCH] t4018: introduce test cases for the internal hunk header patterns Junio C Hamano
2011-12-19 22:57 ` Brandon Casey
2011-12-19 23:17 ` Junio C Hamano
2011-12-20 2:42 ` [PATCH v2] " Brandon Casey
2011-12-20 8:25 ` Jakub Narebski
2011-12-20 15:58 ` Brandon Casey
2011-12-20 9:13 ` Thomas Rast
2011-12-20 19:52 ` Johannes Sixt
2011-12-20 20:08 ` [PATCH] " Junio C Hamano
2011-12-16 17:51 ` [PATCH] attr: map builtin userdiff drivers to well-known extensions Mark Levedahl
2011-12-16 19:28 ` Jeff King
2011-12-16 19:26 ` Philip Oakley
2011-12-16 19:32 ` Jeff King
2011-12-22 0:05 ` Philip Oakley
2011-12-23 5:47 ` Jeff King
2011-12-16 19:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hb0wnv43.fsf@thomas.inf.ethz.ch \
--to=trast@student.ethz.ch \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).