git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Roberts <bpeeluk@yahoo.co.uk>
To: git@vger.kernel.org
Subject: Re: [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject
Date: Tue, 22 Sep 2009 11:39:33 +0100	[thread overview]
Message-ID: <87hbuv5km2.fsf@janet.wally> (raw)
In-Reply-To: <1246310220-16909-1-git-send-email-rleigh@debian.org> (Roger Leigh's message of "Mon, 29 Jun 2009 22:17:00 +0100")

Roger Leigh <rleigh@debian.org> writes:

> Use a regular expression to match text after "Re:" or any text in the
> first pair of square brackets such as "[PATCH n/m]".  This replaces
> the complex hairy string munging with a simple single pattern match.

Is this patch going to get applied? We like to use the '[topic]' format
in Clutter¹ because it looks so much nicer than 'topic:' and it would be
really nice not to have to manually fix the commit when a contributor
sends a patch in the same format.

- Neil

[1] http://git.clutter-project.org/cgit.cgi?url=clutter/log/

  parent reply	other threads:[~2009-09-22 10:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-28 19:38 git mailinfo strips important context from patch subjects Roger Leigh
2009-06-28 20:02 ` Jeff King
2009-06-28 23:04   ` Junio C Hamano
2009-06-29  9:53     ` Andreas Ericsson
2009-06-29  9:55       ` [PATCH] mailinfo: Remove only one set of square brackets Andreas Ericsson
2009-06-29 16:09         ` Junio C Hamano
2009-06-30  5:33         ` Jeff King
2009-06-29 21:17     ` [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject Roger Leigh
2009-06-29 21:26       ` Jakub Narebski
2009-06-29 21:49         ` Roger Leigh
2009-09-22 10:39       ` Neil Roberts [this message]
2009-09-22 12:56         ` [PATCH] builtin-mailinfo.c: Improve the regexp for cleaning up the subject Neil Roberts
2009-09-22 16:15         ` [PATCH] builtin-mailinfo.c: Trim only first pair of square brackets in subject Junio C Hamano
2009-09-22 16:51           ` Neil Roberts
2009-09-23  0:26           ` Jason Holden
2009-06-29 21:34     ` [PATCH 2/2] builtin-mailinfo.c: Free regular expression after use Roger Leigh
2009-06-29 21:36     ` git mailinfo strips important context from patch subjects Roger Leigh
2009-06-28 20:07 ` [PATCH] " Paolo Bonzini
2009-06-29  9:19   ` Andreas Ericsson
2009-06-29 10:21     ` Paolo Bonzini
2009-06-29 10:54       ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbuv5km2.fsf@janet.wally \
    --to=bpeeluk@yahoo.co.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).