From: Samium Gromoff <_deepfire@feelingofgreen.ru>
To: git@vger.kernel.org
Subject: Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS.
Date: Wed, 26 Sep 2007 02:34:25 +0400 [thread overview]
Message-ID: <87hclifk7i.wl@betelheise.deep.net> (raw)
Hello folks,
Without the following applied, git-tag -s gets zeroes into TAG_TMP
in place of the .asc sig, resulting in an unsigned commit.
My repository is located on a NFS share, and I didn't check with NFS factored
out, so it might be more extensive.
I'm not sure what's the policy -- "go and fix Ubuntu, your filesystem
and your kernel", or "let's go the safe way", so there it is.
--- a/git-tag 2007-09-07 22:12:11.000000000 +0400
+++ b/git-tag 2007-09-26 02:19:42.000000000 +0400
@@ -143,7 +143,8 @@
rm -f "$GIT_DIR"/TAG_TMP.asc "$GIT_DIR"/TAG_FINALMSG
if [ "$signed" ]; then
gpg -bsa -u "$username" "$GIT_DIR"/TAG_TMP &&
- cat "$GIT_DIR"/TAG_TMP.asc >>"$GIT_DIR"/TAG_TMP ||
+ cat "$GIT_DIR"/TAG_TMP "$GIT_DIR"/TAG_TMP.asc > "$GIT_DIR"/TAG_TMP_RELAY &&
+ mv "$GIT_DIR"/TAG_TMP_RELAY "$GIT_DIR"/TAG_TMP ||
die "failed to sign the tag with GPG."
fi
object=$(git-mktag < "$GIT_DIR"/TAG_TMP)
Git is 1.5.2.5-2build1/Gutsy.
regards, Samium Gromoff
next reply other threads:[~2007-09-25 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 22:34 Samium Gromoff [this message]
2007-09-25 23:01 ` Git-tag's over-aggressive pipework fails badly on fresh Ubuntu, over NFS Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hclifk7i.wl@betelheise.deep.net \
--to=_deepfire@feelingofgreen.ru \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).