Re: [PATCH] Add --pretty=changelog

[Simon Josefsson <simon@josefsson.org>]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> 1) Indentation should be under the '*'.  Compare (wrong):
>> 
>>         * src/asn1Coding.c, src/asn1Decoding.c, src/asn1Parser.c: Improve
>>           --help output.  Assume getopt_long, since gnulib provides it.
>
> I saw that in your mail already, and I find the style cvs2cl outputs ugly.

Well, if you don't follow the GNU ChangeLog format, then please call
it something else.  The format is well documented.

>> 2) Don't log anything for empty messages:
>> 
>>         * gl/.cvsignore: *** empty log message ***
>> 
>> Possibly, this should be an option.
>
> It does not log anything for empty messages. Not even a colon.

The problem here is that CVS insert '*** empty log message ***' when
you didn't supply a log message, and doing something intelligent with
such logs would be useful.  Plenty of projects that needs cvs2cl
functionality will be coming from the cvs world.

There is plenty of functionality in cvs2cl that I believe a proper
git2cl should support, handling empty CVS commit messages is one,
others would include ignoring files based on a regexp, output in XML
format, put ChangeLog's in sub-directories, show branches and tags.

>> 3) Possible charset problem?  Compare this (correct):
>> 
>>         * configure.in: Fix -Wno-pointer-sign test to respect user-defined
>>         CFLAGS.  Reported by "Diego 'Flameeyes' Pettenò"
>>         <flameeyes@gentoo.org>.
>> 
>> with (wrong):
>> 
>>         * configure.in: Fix -Wno-pointer-sign test to respect user-defined
>>           CFLAGS.  Reported
>> 
>> The git log do seem to contain the correct data, though, from git-log:
>> 
>>     Fix -Wno-pointer-sign test to respect user-defined CFLAGS.  Reported
>>     by "Diego 'Flameeyes' Pettenò" <flameeyes@gentoo.org>.
>
> No charset problem. In Git commit messages, the first line is special. It 
> is the so called "oneline" description. If you wrap the oneline, it's your 
> fault, not Git's.

But I want more than the oneline comment in the ChangeLog?  There is
no size limit on ChangeLog messages, and having as much information as
possible available is better.

Anyway, for now I'll be settling with the (just announced) git2cl
since it gives me the most flexibility.  If/when git core includes
your patch later on, and some of my pet problems are fixed, and my
distribution catches up, I'll be back.

/Simon