From: Collin Funk <collin.funk1@gmail.com>
To: "Jean-Noël AVILA" <jn.avila@free.fr>
Cc: Brad Smith <brad@comstyle.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: Solaris sed
Date: Fri, 13 Jun 2025 13:30:57 -0700 [thread overview]
Message-ID: <87ikkzs7su.fsf@gmail.com> (raw)
In-Reply-To: <5895400.DvuYhMxLoT@cayenne>
Jean-Noël AVILA <jn.avila@free.fr> writes:
> Would it be possible to set up some kind of CI to check for compatibility with
> such systems. This is the second time I introduced regressions without even
> knowing it, and it would be really great to catch them before borking a
> release process.
I'm sure that Solaris packagers are used to patching stuff like this. I
wouldn't feel guilty about it. It is difficult to remember all these
portability quirks.
With GitHub actions you can add Oracle Solaris and OmniOS (based on
illumos, which was based on OpenSolaris) using vmactions [1]. That might
help catch some stuff.
In this case, the build still works even with the broken sed commands.
Not sure if the tests would have caught it though.
Collin
[1] https://github.com/vmactions
next prev parent reply other threads:[~2025-06-13 20:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 3:23 Solaris sed Brad Smith
2025-06-12 3:42 ` Collin Funk
2025-06-12 3:49 ` Brad Smith
2025-06-12 4:16 ` Eli Schwartz
2025-06-12 4:25 ` Collin Funk
2025-06-12 4:26 ` Brad Smith
2025-06-12 4:03 ` Junio C Hamano
2025-06-12 4:13 ` Brad Smith
2025-06-12 4:19 ` Collin Funk
2025-06-13 20:13 ` Jean-Noël AVILA
2025-06-13 20:23 ` Eric Sunshine
2025-06-13 20:30 ` Collin Funk [this message]
2025-06-12 5:50 ` Eric Sunshine
2025-06-12 13:35 ` Paul Smith
2025-06-12 16:40 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2025-06-12 22:52 Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikkzs7su.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=brad@comstyle.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox