From: Sam James <sam@gentoo.org>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH v2] meson: fix perl dependencies for Documentation
Date: Tue, 14 Jan 2025 14:35:00 +0000 [thread overview]
Message-ID: <87ikqhwjjf.fsf@gentoo.org> (raw)
In-Reply-To: <Z4Z0Fxj87XrqdZl7@pks.im> (Patrick Steinhardt's message of "Tue, 14 Jan 2025 15:26:31 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> On Tue, Jan 14, 2025 at 02:03:47PM +0000, Sam James wrote:
>> We need an explicit `depends: documentation_deps` so that all of our
>> Documentation targets know they require asciidoc.conf. This shows up
>> as parallel build failures with it not yet being available.
>>
>> Other targets look OK already.
>>
>> Signed-off-by: Sam James <sam@gentoo.org>
>> ---
>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
>>
>> Documentation/technical/meson.build | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build
>> index 21dfb8b5c9..3a65ee59b3 100644
>> --- a/Documentation/technical/meson.build
>> +++ b/Documentation/technical/meson.build
>> @@ -60,6 +60,7 @@ foreach article : api_docs + articles
>> command: asciidoc_html_options,
>> input: article,
>> output: fs.stem(article) + '.html',
>> + depends: documentation_deps,
>> install: true,
>> install_dir: get_option('datadir') / 'doc/git-doc/technical',
>> )
>
> Okay, this looks good to me now, thanks. One last nit on the subject
> though: as far as I can see the change doesn't have anything to do with
> Perl, so it is somewhat confusing. How about:
>
> meson: fix missing deps for technical articles
Agreed. Not sure where that came from.
I'll send v3 for that then.
>
> Thanks!
>
> Patrick
prev parent reply other threads:[~2025-01-14 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 14:03 [PATCH v2] meson: fix perl dependencies for Documentation Sam James
2025-01-14 14:26 ` Patrick Steinhardt
2025-01-14 14:35 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikqhwjjf.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).