git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@inf.ethz.ch>
To: "René Haber" <rene@habr.de>
Cc: Jeff King <peff@peff.net>, <git@vger.kernel.org>,
	Will Palmer <wmpalmer@gmail.com>
Subject: Re: Bug: pull --rebase with é in name
Date: Mon, 5 Mar 2012 14:04:37 +0100	[thread overview]
Message-ID: <87ipijkxlm.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <0E2B8DE3-1ABD-453F-BCAA-0D693ECA5987@habr.de> ("René Haber"'s message of "Mon, 5 Mar 2012 13:46:39 +0100")

René Haber <rene@habr.de> writes:

> sh -c '                                   
>    . /sw/lib/git-core/git-sh-setup
>     get_author_ident_from_commit 16b94413cbce12531e8f946286851598449d3913
>  '
> GIT_AUTHOR_NAME='Ren'é Haber
> GIT_AUTHOR_EMAIL='rene@habr.de'
> GIT_AUTHOR_DATE='@1329212923 +0100'

I think this is the same issue that we recently discussed on #git-devel,
where some broken versions of sed will fail to match "any character"
with '.' even under LC_ALL=C.  Will "shruggar" Palmer (cc) had this
issue under OS X with a build of GNU sed that ignored LC_*.

You can verify that this is the problem by looking at

  printf "\370\235\204\236\n" | LC_CTYPE=C sed 's/./x/g' | xxd

It should say

  0000000: 7878 7878 0a                             xxxx.

That is, the garbage (if you try to read it as UTF-8) in the printf
string was matched and replaced byte-by-byte with 'x'.  However,
Will was getting the unreplaced results

  0000000: f89d 849e 0a                             .....

I'm not sure he has followed up on that problem; the only hope may be to
get a better 'sed'.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2012-03-05 13:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05  9:59 Bug: pull --rebase with é in name René Haber
2012-03-05 10:26 ` Jeff King
2012-03-05 10:37   ` Thomas Rast
2012-03-05 11:42     ` René Haber
2012-03-05 11:58       ` Jeff King
2012-03-05 12:36         ` Jakub Narebski
2012-03-05 12:46         ` René Haber
2012-03-05 13:04           ` Thomas Rast [this message]
2012-03-05 13:19             ` René Haber
2012-03-05 13:29             ` Jeff King
2012-03-05 13:40               ` Thomas Rast
2012-03-05 13:50                 ` Jeff King
2012-03-05 17:23               ` Junio C Hamano
2012-03-06  8:23                 ` Jeff King
2012-03-06  8:36                 ` Thomas Rast
2012-03-06  9:02                   ` Jeff King
2012-03-06 18:31                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipijkxlm.fsf@thomas.inf.ethz.ch \
    --to=trast@inf.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=rene@habr.de \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).