From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fsck: reject misconfigured fsck.skipList
Date: Thu, 09 Jan 2025 09:00:04 +0100 [thread overview]
Message-ID: <87jzb4ju2j.fsf@iotcl.com> (raw)
In-Reply-To: <xmqqttaatu8h.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
>
> If the value is missing, i.e.,
>
> [fsck]
> skipList
>
> it is a very clear misconfiguration. "We expect a path, but you
> gave me a valueless true". Once a specified value gets to
> oidset_parse_file(), we would die when a specified path cannot be
> opened, so it is not like we want to deliberately tolerate
> misconfiguration (we also die if the value is given as "~t/sl" and
> user "t" does not exist on the system).
>
> Makes sense.
Yeah, I did some testing as well and reviewed the code. Also makes sense
to me.
--
Toon
prev parent reply other threads:[~2025-01-09 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 16:29 [PATCH] fsck: reject misconfigured fsck.skipList Justin Tobler
2025-01-07 17:21 ` Junio C Hamano
2025-01-09 8:00 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzb4ju2j.fsf@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).