From: Andreas Schwab <schwab@linux-m68k.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Scott Moser <scott.moser@chainguard.dev>,
git@vger.kernel.org
Subject: Re: Can dependency on /bin/sh be removed?
Date: Tue, 16 Jul 2024 23:30:59 +0200 [thread overview]
Message-ID: <87jzhlf2i4.fsf@igel.home> (raw)
In-Reply-To: <20240716192307.GA12536@coredump.intra.peff.net> (Jeff King's message of "Tue, 16 Jul 2024 15:23:07 -0400")
On Jul 16 2024, Jeff King wrote:
> Again, it's possible that we could detect that no shell metacharacters
> are in play and do the word-splitting ourselves. But at that point I
> think it should go into run-command's prepare_shell_cmd().
This is what GNU make does (see construct_command_argv_internal), for
performance reason. But run_command is probably not performance
critical.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2024-07-16 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 18:41 Can dependency on /bin/sh be removed? Scott Moser
2024-07-15 20:18 ` Junio C Hamano
2024-07-15 21:46 ` brian m. carlson
2024-07-15 23:52 ` Jeff King
2024-07-16 15:23 ` Scott Moser
2024-07-16 16:32 ` Junio C Hamano
2024-07-16 19:23 ` Jeff King
2024-07-16 20:02 ` Junio C Hamano
2024-07-17 5:52 ` Jeff King
2024-07-16 21:30 ` Andreas Schwab [this message]
2024-07-16 21:40 ` Paul Smith
2024-07-17 5:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzhlf2i4.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=scott.moser@chainguard.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).