From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Dan Jacques <dnj@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
Johannes.Schindelin@gmx.de,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH v8 0/5] RUNTIME_PREFIX relocatable Git
Date: Wed, 11 Apr 2018 09:14:50 +0200 [thread overview]
Message-ID: <87k1teb4et.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180410150546.38062-1-dnj@google.com>
On Tue, Apr 10 2018, Dan Jacques wrote:
> This is a minor update based on comments from the v6 series.
> I'm hoping this set is good to go!
This looks to me. Thanks!
> - Rebased on top of "master".
Probably useful for others to have the interdiff between this and
v7. Here it is:
$ git tbdiff origin/master b329fde5a6 2b1ed6a79a
1: 776c7d6083 = 1: 4943ec6581 Makefile: generate Perl header from template file
2: 0cded81572 ! 2: 29223250da Makefile: add Perl runtime prefix support
@@ -52,10 +52,9 @@
prefix = $(HOME)
@@
-
mandir_relative = $(patsubst $(prefix)/%,%,$(mandir))
infodir_relative = $(patsubst $(prefix)/%,%,$(infodir))
-+gitexecdir_relative = $(patsubst $(prefix)/%,%,$(gitexecdir))
+ gitexecdir_relative = $(patsubst $(prefix)/%,%,$(gitexecdir))
+localedir_relative = $(patsubst $(prefix)/%,%,$(localedir))
htmldir_relative = $(patsubst $(prefix)/%,%,$(htmldir))
+perllibdir_relative = $(patsubst $(prefix)/%,%,$(perllibdir))
@@ -68,7 +67,7 @@
localedir_SQ = $(subst ','\'',$(localedir))
+localedir_relative_SQ = $(subst ','\'',$(localedir_relative))
gitexecdir_SQ = $(subst ','\'',$(gitexecdir))
-+gitexecdir_relative_SQ = $(subst ','\'',$(gitexecdir_relative))
+ gitexecdir_relative_SQ = $(subst ','\'',$(gitexecdir_relative))
template_dir_SQ = $(subst ','\'',$(template_dir))
htmldir_relative_SQ = $(subst ','\'',$(htmldir_relative))
prefix_SQ = $(subst ','\'',$(prefix))
3: a0e41f5f41 ! 3: 5220baf80e exec_cmd: RUNTIME_PREFIX on some POSIX systems
@@ -109,6 +109,8 @@
+
git_setup_gettext();
+ initialize_the_repository();
+
attr_start();
- git_extract_argv0_path(argv[0]);
4: b25be6e56d = 4: 57dcc5203e exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows
5: b329fde5a6 = 5: 2b1ed6a79a mingw/msvc: use the new-style RUNTIME_PREFIX helper
prev parent reply other threads:[~2018-04-11 7:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:05 [PATCH v8 0/5] RUNTIME_PREFIX relocatable Git Dan Jacques
2018-04-10 15:05 ` [PATCH v8 1/5] Makefile: generate Perl header from template file Dan Jacques
2018-04-10 15:05 ` [PATCH v8 2/5] Makefile: add Perl runtime prefix support Dan Jacques
2018-04-10 15:05 ` [PATCH v8 3/5] exec_cmd: RUNTIME_PREFIX on some POSIX systems Dan Jacques
2018-04-10 15:05 ` [PATCH v8 4/5] exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows Dan Jacques
2018-04-10 15:05 ` [PATCH v8 5/5] mingw/msvc: use the new-style RUNTIME_PREFIX helper Dan Jacques
2018-04-11 6:21 ` [PATCH v8 0/5] RUNTIME_PREFIX relocatable Git Junio C Hamano
2018-04-11 7:14 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1teb4et.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).