From: Vijay Lakshminarayanan <laksvij@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Conrad Irwin <conrad.irwin@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Disallow creating ambiguous branch names by default
Date: Thu, 18 Aug 2011 09:05:57 +0530 [thread overview]
Message-ID: <87k4abfl2a.fsf@gmail.com> (raw)
In-Reply-To: <7vhb5fev8a.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 17 Aug 2011 11:41:41 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> We should be giving these warning messages immediately after creating
> potentially problematic refs, i.e. just after "git branch v1.0.0" and
> "git checkout -b v1.0.0". The user experience should look like this
> instead:
>
> $ git branch v1.0.0
> warning: refname 'v1.0.0' is ambiguous.
> advice: you may want to rename it to an unambigous name with
> advice: git branch -m v1.0.0 v1.0.0-branch
> $ git branch -m v1.0.0 v1.0.0-branch ;# thanks for an advice
>
> $ git checkout -b v1.0.0
> warning: refname 'v1.0.0' is ambiguous.
> advice: you may want to rename it to an unambigous name with
> advice: git branch -m v1.0.0-branch-2
> $ git branch -m v1.0.0-branch-2 ;# thanks for an advice
I'm not familiar with the git codebase, but I'm guessing this is
ambiguous because there's already a tag by name v1.0.0. /If/ that's the
case, wouldn't be be prudent to explain why the branch name is
ambiguous?
Just my 2c.
--
Cheers
~vijay
Gnus should be more complicated.
next prev parent reply other threads:[~2011-08-18 3:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 8:21 [PATCH] Disallow creating ambiguous branch names by default Conrad Irwin
2011-08-17 18:41 ` Junio C Hamano
2011-08-18 3:35 ` Vijay Lakshminarayanan [this message]
2011-08-18 13:53 ` Stephen Bash
2011-08-19 18:07 ` Conrad Irwin
2011-08-19 18:15 ` Stephen Bash
2011-08-19 18:14 ` Conrad Irwin
2011-08-19 20:49 ` Junio C Hamano
2011-08-19 21:07 ` Conrad Irwin
2011-08-19 21:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4abfl2a.fsf@gmail.com \
--to=laksvij@gmail.com \
--cc=conrad.irwin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).