From: "David Kågedal" <davidk@lysator.liu.se>
To: git@vger.kernel.org
Subject: [PATCH] Make the output of "git svn clone" less confusing.
Date: Mon, 15 Oct 2007 17:21:10 +0200 [thread overview]
Message-ID: <87k5poflp5.fsf@lysator.liu.se> (raw)
The problem is that the first thing it prints is
Initialized empty Git repository in .git/
even if actually created a subdirectory and changed into it first. But to the
user, it looks like it is creating a .git/ dir in the directory he/she is
started git from.
---
git-svn.perl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
This change makes it more chatty, which might not be a good thing. But
I think the previous output was worse.
diff --git a/git-svn.perl b/git-svn.perl
index 777e436..d4450ca 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -286,6 +286,7 @@ sub do_git_init_db {
sub init_subdir {
my $repo_path = shift or return;
+ print "Creating directory $repo_path\n";
mkpath([$repo_path]) unless -d $repo_path;
chdir $repo_path or die "Couldn't chdir to $repo_path: $!\n";
$ENV{GIT_DIR} = '.git';
--
1.5.3.4.213.gb3127-dirty
--
David Kågedal
next reply other threads:[~2007-10-15 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 15:21 David Kågedal [this message]
2007-10-16 9:32 ` [PATCH] Make the output of "git svn clone" less confusing Eric Wong
2007-10-16 11:00 ` David Kågedal
2007-10-18 7:06 ` Shawn O. Pearce
2007-10-18 10:33 ` Eric Wong
[not found] ` <87abqgiqsj.fsf@lysator.liu.se>
2007-10-18 17:14 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k5poflp5.fsf@lysator.liu.se \
--to=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).