git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Stan Hu <stanhu@gmail.com>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH RESEND] sane-ctype: fix compiler error on Amazon Linux 2
Date: Thu, 10 Jul 2025 12:17:56 +0200	[thread overview]
Message-ID: <87ldowcpt7.fsf@iotcl.com> (raw)
In-Reply-To: <aG-HMnO11lCYgPiY@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Meanwhile, I'll include the patch as an attachment.

I have tested the patch on the Docker image we saw the failure on and
this patch fixes the issue.

If anyone is curious, on that system <ctype.h> is included through:

    In file included from /usr/include/openssl/kssl.h:72:0,
                     from /usr/include/openssl/ssl.h:165,
                     from git-compat-util.h:226

Doesn't matter much, because the patch makes sense to me.

-- 
Cheers,
Toon

  reply	other threads:[~2025-07-10 10:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10  9:12 [PATCH RESEND] sane-ctype: fix compiler error on Amazon Linux 2 Patrick Steinhardt
2025-07-10  9:14 ` Patrick Steinhardt
2025-07-10  9:26   ` Patrick Steinhardt
2025-07-10 10:17     ` Toon Claes [this message]
2025-07-10 21:01     ` Junio C Hamano
2025-07-11  7:56       ` Patrick Steinhardt
2025-07-11 15:11         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldowcpt7.fsf@iotcl.com \
    --to=toon@iotcl.com \
    --cc=git@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=ps@pks.im \
    --cc=stanhu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).