From: Toon Claes <toon@iotcl.com>
To: Jeff King <peff@peff.net>, Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [PATCH 0/8] ci: consolidate test variables
Date: Wed, 28 Oct 2026 15:40:54 +0100 [thread overview]
Message-ID: <87mrrxzy4p.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <20261027212431.GB774120@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> On Tue, Oct 27, 2026 at 09:18:20AM +0100, Patrick Steinhardt wrote:
>
>> this patch series consolidates our test variables as a follow up on the
>> discussions in [1].
>
> Thanks for following up. 1-7 seem obviously good to me.
Yes, 1-7 look good and are pretty much noncontroversial.
> I'm lukewarm on the final patch (and left a comment there), but if you
> really love it, I can live with it. :)
I understand the stance of both of you. To be honest, I don't really
have an opinion. The cleanest fix probably would be to split the build
flags from test flags, because it's a mix now and Peff prefers to have
them all fixed, while Patrick likes to change them run-by-run. Although,
that would probably lead this patch series beyond their intentions.
--
Laters,
Toon
prev parent reply other threads:[~2026-10-28 14:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 8:18 [PATCH 0/8] ci: consolidate test variables Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 1/8] ci: consolidate setup of test environment Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 2/8] ci/lib: always set GIT_TEST_USE_SET_E on Linux jobs Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 3/8] ci/lib: deduplicate test variables by pattern matching Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 4/8] ci/lib: merge switches for specific job names Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 5/8] t: honor default ref storage format Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 6/8] ci/lib: add another NO_RUST build using glibc Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 7/8] ci: don't override initial branch name in testbed job Patrick Steinhardt
2026-10-27 8:18 ` [PATCH 8/8] t/test-lib: make feature-testbed job more accessible Patrick Steinhardt
2026-10-27 14:53 ` Phillip Wood
2026-10-27 20:59 ` Junio C Hamano
2026-10-28 7:41 ` Patrick Steinhardt
2026-10-27 21:23 ` Jeff King
2026-10-27 21:47 ` Junio C Hamano
2026-10-28 7:39 ` Patrick Steinhardt
2026-10-28 14:33 ` Phillip Wood
2026-10-27 15:00 ` [PATCH 0/8] ci: consolidate test variables Phillip Wood
2026-10-27 20:59 ` Junio C Hamano
2026-10-27 21:24 ` Jeff King
2026-10-28 14:40 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrrxzy4p.fsf@dev.null.iotcl.com.invalid \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox