git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jul 2025, #08; Mon, 28)
Date: Tue, 29 Jul 2025 09:37:47 +0200	[thread overview]
Message-ID: <87ms8na1mc.fsf@iotcl.com> (raw)
In-Reply-To: <xmqqo6t3sqrc.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> * ps/object-file-wo-the-repository (2025-07-16) 17 commits
>  - object-file: get rid of `the_repository` in index-related functions
>  - object-file: get rid of `the_repository` in `force_object_loose()`
>  - object-file: get rid of `the_repository` in `read_loose_object()`
>  - object-file: get rid of `the_repository` in loose object iterators
>  - object-file: remove declaration for `for_each_file_in_obj_subdir()`
>  - object-file: inline `for_each_loose_file_in_objdir_buf()`
>  - object-file: get rid of `the_repository` when writing objects
>  - odb: introduce `odb_write_object()`
>  - loose: write loose objects map via their source
>  - object-file: get rid of `the_repository` in `finalize_object_file()`
>  - object-file: get rid of `the_repository` in `loose_object_info()`
>  - object-file: get rid of `the_repository` when freshening objects
>  - object-file: inline `check_and_freshen()` functions
>  - object-file: get rid of `the_repository` in `has_loose_object()`
>  - object-file: stop using `the_hash_algo`
>  - object-file: fix -Wsign-compare warnings
>  - Merge branch 'ps/object-store' into ps/object-file-wo-the-repository
>
>  Reduce implicit assumption and dependence on the_repository in the
>  object-file subsystem.
>
>  Comments?
>  source: <20250717-pks-object-file-wo-the-repository-v2-0-36d2cd6c700e@pks.im>

I did do a thorough review on v1 in the past and did a little less
thorough review on v2, but the range-diff is tiny anyway.

Version two removes the controversial commits around global config. With
this, this patch series is not able to drop USE_THE_REPOSITORY_VARIABLE
from the object-file.c yet. Nevertheless, the whole series is still
worthwhile to me.


-- 
Cheers,
Toon

  parent reply	other threads:[~2025-07-29  7:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  1:57 What's cooking in git.git (Jul 2025, #08; Mon, 28) Junio C Hamano
2025-07-29  2:05 ` Junio C Hamano
2025-07-29  6:15 ` Patrick Steinhardt
2025-07-29  7:37 ` Toon Claes [this message]
2025-07-29 15:30   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ms8na1mc.fsf@iotcl.com \
    --to=toon@iotcl.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).