git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Jeffrey Walton <noloader@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: Git build on antique PowerMac
Date: Thu, 09 May 2019 00:27:56 +0200	[thread overview]
Message-ID: <87mujwh98z.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CAPig+cSzsmeHp1S5WG3TVXEyZKt9eVrsCsWEkpwbNUZK_SJ53g@mail.gmail.com>


On Sun, May 05 2019, Eric Sunshine wrote:

> On Sun, May 5, 2019 at 3:43 PM Jeffrey Walton <noloader@gmail.com> wrote:
>> I have a PowerMac I use for testing. [...]
>> make -C t/ all
>> readline() on unopened filehandle       test_must_fail
>> run_sub_test_lib_test  at check-non-portable-shell.pl line 34.
>> Modification of a read-only value attempted at
>> check-non-portable-shell.pl line 34.
>> make[1]: *** [test-lint-shell-syntax] Error 255
>>
>> Does anyone want to take a shot at this antique system? I can provide
>> SSH access with root.
>
> As the author of the code triggering that problem, I can take a look
> at it. (You already have my public SSH key on your Solaris box.)
>
> Given [1], I can see (I guess) why it's complaining about modification
> of a read-only variable. However, the unopened filehandle complaint
> looks odd.
>
> [1]: https://www.perlmonks.org/?node_id=570712#default_unlocalized

It's because "while (<>) { readline }" didn't use to be supported until
5.10, and he's on 5.8.

    $ seq 1 4 | ./miniperl -we 'print $]; while (<>) { chomp; print "$.: $_ -> " . readline }; print "\n"'
    readline() on unopened filehandle 1: 1 ->  at -e line 1.
    Use of uninitialized value in concatenation (.) or string at -e line 1.
    readline() on unopened filehandle 2: 2 ->  at -e line 1.
    readline() on unopened filehandle 3: 3 ->  at -e line 1.
    readline() on unopened filehandle 4: 4 ->  at -e line 1.
    5.009004
    $ seq 1 4 | perl -we 'print $]; while (<>) { chomp; print "$.: $_ -> " . readline }; print "\n"'
    5.0280011: 1 -> 2
    3: 3 -> 4

  reply	other threads:[~2019-05-08 22:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 19:42 Git build on antique PowerMac Jeffrey Walton
2019-05-05 20:14 ` SZEDER Gábor
2019-05-05 20:47 ` Eric Sunshine
2019-05-08 22:27   ` Ævar Arnfjörð Bjarmason [this message]
2019-05-09  9:10     ` Eric Sunshine
2019-05-09 10:20 ` [PATCH] check-non-portable-shell: support Perl versions older than 5.10 Eric Sunshine
2019-05-09 12:33   ` Ævar Arnfjörð Bjarmason
2019-05-10 20:39     ` Eric Sunshine
2019-05-11  0:18   ` [PATCH v2] " Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mujwh98z.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=noloader@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).