git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Dani Koretsky <Dani@cybereason.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG]: git checkout on a new tag with current HEAD shows "head detached" at previous tag
Date: Tue, 05 Feb 2019 16:16:24 +0100	[thread overview]
Message-ID: <87munal0zb.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <CANcfovV3Pq3pubtNq4HCSZOJ5OC9dVSm+19VkOiQimAH+fttYw@mail.gmail.com>


On Tue, Feb 05 2019, Dani Koretsky wrote:

> I have 2 tags such as release-17.6.230 and release-17.6.220:
> If I'm changing commits, all works as expected.
>
> If however both are pointing to the same commit, the output is as follows:
>
> git checkout release-17.6.220
> git status
> HEAD detached at release-17.6.220
>
> now if I run:
> git checkout release-17.6.230
> git status
> HEAD detached at release-17.6.220
>
> Which is theoretically correct, but I'd expect after checking out a
> certain tag I'd be see that specific tag...
>
> Sorry if this is intended behavior, I couldn't find clear mention of
> this behavior on the git checkout documentation online..
>
> Let me know if I can help in anyway.

You're right about this issue. I haven't dug deep into this, but just
enough to see why this is. When we "git checkout" something we write to
the reflog that we moved to such-and-such a ref, we then consult the
reflog when you run "git status" to see what we detached the HEAD from.

As you can see if you run "git reflog" after you check out the first and
second tag, that entry doesn't change, and we still note just the first
tag you checked out.

This is going to be because of a short-circuit behavior where we see "oh
we already checked this out".

Maybe that needs to be fixed as a bug, but would have more implications,
i.e. are there cases where you can flip-flop and end up spamming the
reflog, should the post-checkout hook run or not in those cases, etc.

  parent reply	other threads:[~2019-02-05 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05  9:19 [BUG]: git checkout on a new tag with current HEAD shows "head detached" at previous tag Dani Koretsky
2019-02-05 15:02 ` Randall S. Becker
2019-02-05 15:16 ` Ævar Arnfjörð Bjarmason [this message]
2019-02-05 15:23   ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87munal0zb.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=Dani@cybereason.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).