From: David Michael <fedora.dm0@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule
Date: Sun, 26 Oct 2014 13:33:53 -0400 [thread overview]
Message-ID: <87mw8iag72.fsf@gmail.com> (raw)
The XL C compiler can fail due to mixing library path and object
file arguments, for example when linking git while building with
"gmake LDFLAGS=-L$prefix/lib". This moves the ALL_LDFLAGS variable
expansion in the git executable rule to be consistent with all the
other linking rules.
Signed-off-by: David Michael <fedora.dm0@gmail.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index fcd51ac..827006b 100644
--- a/Makefile
+++ b/Makefile
@@ -1610,8 +1610,8 @@ git.sp git.s git.o: EXTRA_CPPFLAGS = \
'-DGIT_INFO_PATH="$(infodir_relative_SQ)"'
git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS)
- $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ git.o \
- $(BUILTIN_OBJS) $(ALL_LDFLAGS) $(LIBS)
+ $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) git.o \
+ $(BUILTIN_OBJS) $(LIBS)
help.sp help.s help.o: common-cmds.h
--
1.9.3
next reply other threads:[~2014-10-26 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:33 David Michael [this message]
2014-10-26 17:45 ` [PATCH 2/3] Makefile: Reorder linker flags in the git executable rule Eric Sunshine
2014-10-26 18:35 ` Jeff King
2014-10-26 18:54 ` David Michael
2014-10-27 5:17 ` Jeff King
2014-10-27 17:42 ` Junio C Hamano
2014-10-28 22:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw8iag72.fsf@gmail.com \
--to=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).