git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-gui: span widgets over the full file output area in the blame view
Date: Fri, 21 Oct 2011 22:41:43 +0100	[thread overview]
Message-ID: <87mxcu3tuw.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <16d7f36e4d24d8816035f934836395e5f854f1d3.1319138993.git.bert.wesarg@googlemail.com> (Bert Wesarg's message of "Thu, 20 Oct 2011 21:30:30 +0200")

Bert Wesarg <bert.wesarg@googlemail.com> writes:

>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>---
> lib/blame.tcl |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/lib/blame.tcl b/lib/blame.tcl
>index 49eae19..b031e66 100644
>--- a/lib/blame.tcl
>+++ b/lib/blame.tcl
>@@ -219,7 +219,8 @@ constructor new {i_commit i_path i_jump} {
> 	eval grid $w_columns $w.file_pane.out.sby -sticky nsew
> 	grid conf \
> 		$w.file_pane.out.sbx \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		-sticky we
> 	grid columnconfigure \
> 		$w.file_pane.out \
>@@ -229,12 +230,14 @@ constructor new {i_commit i_path i_jump} {
> 
> 	set finder [::searchbar::new \
> 		$w.file_pane.out.ff $w_file \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		]
> 
> 	set gotoline [::linebar::new \
> 		$w.file_pane.out.lf $w_file \
>-		-column [expr {[llength $w_columns] - 1}] \
>+		-column 0 \
>+		-columnspan [expr {[llength $w_columns] + 1}] \
> 		]
> 
> 	set w_cviewer $w.file_pane.cm.t

Looks good. Applied.
-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD

      reply	other threads:[~2011-10-21 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 19:30 [PATCH] git-gui: span widgets over the full file output area in the blame view Bert Wesarg
2011-10-21 21:41 ` Pat Thoyts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxcu3tuw.fsf@fox.patthoyts.tk \
    --to=patthoyts@users.sourceforge.net \
    --cc=bert.wesarg@googlemail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).