git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] git-submodule: Avoid printing a spurious message.
@ 2008-11-11 21:09 Alexandre Julliard
  2008-11-12  0:07 ` Johannes Schindelin
  2008-11-12  0:51 ` Junio C Hamano
  0 siblings, 2 replies; 3+ messages in thread
From: Alexandre Julliard @ 2008-11-11 21:09 UTC (permalink / raw)
  To: git

Fix 'git submodule update' to avoid printing a spurious "Maybe you want
to use 'update --init'?" once for every uninitialized submodule it
encounters.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
 git-submodule.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-submodule.sh b/git-submodule.sh
index b63e5c3..220d94e 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -323,7 +323,7 @@ cmd_update()
 			# Only mention uninitialized submodules when its
 			# path have been specified
 			test "$#" != "0" &&
-			say "Submodule path '$path' not initialized"
+			say "Submodule path '$path' not initialized" &&
 			say "Maybe you want to use 'update --init'?"
 			continue
 		fi
-- 
1.6.0.4.637.ga2ff4

-- 
Alexandre Julliard
julliard@winehq.org

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] git-submodule: Avoid printing a spurious message.
  2008-11-11 21:09 [PATCH] git-submodule: Avoid printing a spurious message Alexandre Julliard
@ 2008-11-12  0:07 ` Johannes Schindelin
  2008-11-12  0:51 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Johannes Schindelin @ 2008-11-12  0:07 UTC (permalink / raw)
  To: Alexandre Julliard; +Cc: git

Hi,

On Tue, 11 Nov 2008, Alexandre Julliard wrote:

> Fix 'git submodule update' to avoid printing a spurious "Maybe you want
> to use 'update --init'?" once for every uninitialized submodule it
> encounters.
> 
> Signed-off-by: Alexandre Julliard <julliard@winehq.org>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index b63e5c3..220d94e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -323,7 +323,7 @@ cmd_update()
>  			# Only mention uninitialized submodules when its
>  			# path have been specified
>  			test "$#" != "0" &&
> -			say "Submodule path '$path' not initialized"
> +			say "Submodule path '$path' not initialized" &&
>  			say "Maybe you want to use 'update --init'?"
>  			continue
>  		fi

Ooops, thanks (& ACK).

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] git-submodule: Avoid printing a spurious message.
  2008-11-11 21:09 [PATCH] git-submodule: Avoid printing a spurious message Alexandre Julliard
  2008-11-12  0:07 ` Johannes Schindelin
@ 2008-11-12  0:51 ` Junio C Hamano
  1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-11-12  0:51 UTC (permalink / raw)
  To: Alexandre Julliard; +Cc: git

Good eyes, thanks.  Will apply to 'maint'.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-12  0:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11 21:09 [PATCH] git-submodule: Avoid printing a spurious message Alexandre Julliard
2008-11-12  0:07 ` Johannes Schindelin
2008-11-12  0:51 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).