From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?S=E9bastien?= Cevey Subject: Re: [PATCH] gitweb: Optional grouping of projects by category Date: Wed, 03 Dec 2008 15:29:44 +0100 Message-ID: <87oczt1gdj.wl%seb@cine7.net> References: <87wsei1uvp.wl%seb@cine7.net> <200812030036.13562.jnareb@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, Junio C Hamano , Petr Baudis , Gustavo Sverzut Barbieri To: Jakub Narebski X-From: git-owner@vger.kernel.org Wed Dec 03 15:29:58 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7sjj-0008Mo-Nr for gcvg-git-2@gmane.org; Wed, 03 Dec 2008 15:29:56 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750912AbYLCO2j convert rfc822-to-quoted-printable (ORCPT ); Wed, 3 Dec 2008 09:28:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751138AbYLCO2j (ORCPT ); Wed, 3 Dec 2008 09:28:39 -0500 Received: from smtp.nimag.net ([62.220.136.11]:49211 "EHLO smtp.nimag.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbYLCO2i convert rfc822-to-8bit (ORCPT ); Wed, 3 Dec 2008 09:28:38 -0500 Received: from crookshanks.cine7.net (85-218-46-19.dclient.lsne.ch [85.218.46.19]) by smtp.nimag.net (Postfix) with ESMTP id 23DBBCB0A8D; Wed, 3 Dec 2008 15:28:35 +0100 (CET) In-Reply-To: <200812030036.13562.jnareb@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) X-Message-Flag: OUTLOOK ERROR: Large chicken feathers stuck in power supply fan. Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: At Wed, 3 Dec 2008 00:36:12 +0100, Jakub Narebski wrote: Hello, > > This adds the GITWEB_GROUP_CATEGORIES option which, if enabled, wil= l > > result in grouping projects by category on the project list page. >=20 > Should this really be build time configuration (to set default value)= ? Probably not, I removed it. I corrected my patch using all your other comments and sent it again in another email. > Unfortunately it looks like you hit the edge of feature freeze again. Damn, time is always against me :-) Hope it's gonna be included eventually! > By the way, there was alternate patch series by Gustavo Sverzut Barbi= eri > on 29 July 2008 adding categories support to gitweb: > http://thread.gmane.org/gmane.comp.version-control.git/90553 > with live demo at http://staff.get-e.org/ Right, I saw that in July but it's not exactly the same feature (arbitrary category in config vs repository path). I think both are useful independently.. If both get supported, there should be a way to do it modularly to reuse code though. Btw you can see a demo of my patch here: http://inso.cc/git > Here is and important issue when adding categories support: how divis= ion > into categories interplays with sorting of projects. I kept it how it was but added a comment in the commitlog. =20 > Another issue is how categories interplay with limiting number of > projects displayed. Currently it is no issue, because projects list > page is not divided into pages, but I think you didn't address this > in your patch. I think it's now better in v2, I added support for $from/$to also in the categorized project list. Thanks for your in depth comments, and I hope this patch will get applied in the near future! --=20 S=E9bastien Cevey / inso.cc " The question of whether a computer can think is no more interesting than the question of whether a submarine can swim. " Edsger W. Dijkstra =20